Bug 5918

Summary: When AddPatronLists is set to "general" and EnhancedMessagingPreferences is set, messaging prefs not copied from defaults
Product: Koha Reporter: D Ruth Holloway <ruth>
Component: PatronsAssignee: Kyle M Hall <kyle.m.hall>
Status: CLOSED FIXED QA Contact: Bugs List <koha-bugs>
Severity: major    
Priority: PATCH-Sent (DO NOT USE) CC: chris, gmcharlt, koha.sekjal
Version: 3.4   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Bug 5918 : Use the default messaging preferences if the user does not select any
Bug 5918 : Use the default messaging preferences if the user does not select any

Description D Ruth Holloway 2011-03-21 13:22:12 UTC
the reason here seems to be that, in memberentry.pl, the Enhanced Preferences form is populated by data from the categorycode. However, when a new form is created using AddPatronLists as "general", no categorycode exists at that point, so the form is not populated.  

It would probably be a good idea to unset "setting_messaging_prefs" and/or perform some other checking to see if--on save--we need to fetch in the default preferences on a new borrower.

Ideas welcome.
Comment 1 Chris Cormack 2011-05-31 22:34:49 UTC
Created attachment 4322 [details] [review]
Bug 5918 : Use the default messaging preferences if the user does not select any
Comment 2 Jesse Weaver 2011-06-01 00:10:52 UTC
Created attachment 4323 [details] [review]
Bug 5918 : Use the default messaging preferences if the user does not select any

Signed-off-by: Jesse Weaver <pianohacker@gmail.com>
Comment 3 Ian Walls 2011-06-01 14:23:44 UTC
Tested and confirmed, marking as Passed QA
Comment 4 Chris Cormack 2011-06-01 21:19:40 UTC
Pushed to master, please test