| Summary: | Enumchron does not show up on item details screen in staff client | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jared Camins-Esakov <jcamins> |
| Component: | Staff interface | Assignee: | Jared Camins-Esakov <jcamins> |
| Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
| Severity: | enhancement | ||
| Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, claire.hernandez, gmcharlt, nengard |
| Version: | 3.4 | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
patch
follow-up patch signed patch (second) |
||
|
Description
Jared Camins-Esakov
2011-03-21 18:55:41 UTC
Created attachment 3408 [details] [review] patch Pushed, please test This works properly for me. Created attachment 3677 [details] [review] follow-up patch Follow-up patch to fix unfortunate line wrapping on More details page. Original patch submitted before the feature freeze, so the follow up patch is still eligible, please sign off. - The patch applies - The template displays "Serial enumeration" - But the var is never set in moredetail.pl :( and the template seems called only by it $ grep -R "moredetail.tmpl" * | grep -v po catalogue/moredetail.pl: 'catalogue/moredetail.tmpl'), $ grep enumchron catalogue/moredetail.pl $ Do I miss something? enumchron is inside the ITEM_DATA loop, which is populated with @items. @items is populated by GetItemsInfo, which does SELECT items.*, So enumchron is being passed to the template. All that was being tested here was the follow up patch (the original one is already in master) which is purely a cosmetic change. Created attachment 3806 [details] [review] signed patch (second) oops... I am ashamed of my mistake. Don't be ashamed, it took me quite a while to track it down, and Ive been doing Koha for nearly 12 years now. You are all doing excellently. Pushed, please test This bug is mentioned in: Bug 5921: Add enumchron to the items detail page http://lists.koha-community.org/pipermail/koha-patches/2011-March/014201.html Seems to be working now. Closing. |