Bug 5932

Summary:	subroutine itemdata to be replaced in C4::Serials
Product:	Koha	Reporter:	Colin Campbell <colin.campbell>
Component:	Serials	Assignee:	Colin Campbell <colin.campbell>
Status:	CLOSED FIXED	QA Contact:	Bugs List <koha-bugs>
Severity:	enhancement
Priority:	PATCH-Sent (DO NOT USE)	CC:	chris, julian.maurice
Version:	unspecified
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	---
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:
Circulation function:
Attachments:	Proposed patch

Description Colin Campbell 2011-03-22 14:59:28 UTC

C4::Serials has an internal subroutine itemdata which retrieves all the data from items and biblioitems for a given barcode. Its only use is as a boolean check of whether the given barcode has been assigned or not. The current functionality clearly does not belong in C4::Serials.

Replace with a with a lighter function which only returns the info we are interested in, pending clean up of the Item interface. Should make code more maintainable/redeable and possibly save a couple of cpu cycles.

Comment 1 Colin Campbell 2011-03-22 15:07:18 UTC

Created attachment 3398 [details] [review]
Proposed patch

Comment 2 Julian Maurice 2011-03-24 09:49:58 UTC

I don't see big performance improvement, but it works.
Signed off.

Comment 3 Chris Cormack 2011-03-27 08:21:19 UTC

Patch pushed, please test