Summary: | Highlight holds on check-in | ||
---|---|---|---|
Product: | Koha | Reporter: | Jared Camins-Esakov <jcamins> |
Component: | Circulation | Assignee: | Kyle M Hall <kyle.m.hall> |
Status: | In Discussion --- | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | gmcharlt, martin.renvoize, nick, tmisilo, veron, viktor.sarge |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: | 5956 Highlight holds on chech-in |
Description
Jared Camins-Esakov
2011-03-25 22:07:08 UTC
There is no highlighting for reserved books on the return screen in current versions of Koha. Created attachment 28858 [details] [review] 5956 Highlight holds on chech-in This patch adds a flag in returns.pl if the returned books have reservervations. The flag is picked up by returns.tt and displays a warning using the "Note" field and CSS-class already in place. Note that this differs from the atcual suggestion from Jared, but using the note field instead of making the title red felt that it kept it more consistent. Apologies if the commit message hints at the fact that I'm still learning Git. Test plan: * Return both reserved and not reserved books and verify that the reserved books are not highlighted * Install the patch * Return both reserved and not reserved books again and verify that reserved books are now highlighted in the "Notes" field. Please note - I see that I omitted "Bug" as the first word of the commit. That will make it impossible to sign of on the bug from the sandboxes. I'm not yet clear on how to resubmit a patch correctly but will be careful to write correctly formated commits in the future. I tested on a sandbox and found that the highlighting (note in red, not highlighting of row) only occurs on confirmation of a hold. I think the intention is that if someone checks in a reserved book, doesn't see the message, then checks in a book with no reserves, they would still see the highlighting even without having confirmed the hold. Thanks for catching this Nick - that makes revisiting the code a must. I'll look into it but as I'm on vacation right now it might be a while, so if feel free if anyone sees where the patch is lacking. (In reply to Nick Clemens from comment #5) > I tested on a sandbox and found that the highlighting (note in red, not > highlighting of row) only occurs on confirmation of a hold. > > I think the intention is that if someone checks in a reserved book, doesn't > see the message, then checks in a book with no reserves, they would still > see the highlighting even without having confirmed the hold. |