Summary: | Add search link for analytics to serial records | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | MARC Bibliographic data support | Assignee: | Katrin Fischer <katrin.fischer> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | enhancement | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, jcamins, koha.sekjal, lculber, m.de.rooy, nengard |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Proposed patch
Rebased patch. Signed-off patch Signed-off patch (reposted) |
Description
Katrin Fischer
2011-03-27 19:32:43 UTC
Created attachment 3446 [details] [review] Proposed patch ../5959.patch:254: trailing whitespace. error: patch failed: C4/XSLT.pm:131 error: C4/XSLT.pm: patch does not apply error: patch failed: kohaversion.pl:16 error: kohaversion.pl: patch does not apply Is it perhaps an idea to put functionality and installation into 2 patches?? The installation patch is not that interesting for testing and gets often much sooner out of date? I think the installation part needs testing too. ;) I think the problem here is, that another XSLT change was pushed shortly before I sent my patch. I will rebase and resent, the conflicts should not be too hard to fix. Created attachment 3494 [details] [review] Rebased patch. (In reply to comment #3) > I think the installation part needs testing too. ;) > I think the problem here is, that another XSLT change was pushed shortly before > I sent my patch. I will rebase and resent, the conflicts should not be too hard > to fix. Install part should obviously be tested too, of course. But if you split functionality and installation, you will not be rebasing every two days ;) Please note that your patch does not even apply already any more on current master due to db revs. Will look to the functional part now.. I have rebased and am signing off on this. Created attachment 3525 [details]
Signed-off patch
Signed-off patch, rebased to latest Master.
Comment on attachment 3525 [details]
Signed-off patch
Attachment is not viewable in your browser because its MIME type (application/octet-stream) is not one that your browser is able to display.
Created attachment 3527 [details] [review] Signed-off patch (reposted) Marcel, I think I may be cursed. Reposting signed-off patch. Regards, Jared (In reply to comment #9) > Created attachment 3527 [details] [review] > Signed-off patch (reposted) > Marcel, > I think I may be cursed. Reposting signed-off patch. > Regards, > Jared Patch applies fine now. Thanks. Only still wonder about the analytics stuff. Pushed, please test Can someone please explain to me what this does for the manual? I need small words here :) This bug is mentioned in: Bug 5959: Add search link for analytics to serial records http://lists.koha-community.org/pipermail/koha-patches/2011-March/014242.html Bug 5959: Add search link for analytics to serial records http://lists.koha-community.org/pipermail/koha-patches/2011-March/014355.html I realize I am coming in late aboutthis, but we just noticed that we hadn't taken the indicators into consideration about whether the links should even display. Had anyone else looked at the indicators? This works on master. The links can be removed from display using CSS: .analytics {display: none;} Linda - you are right, indicators are not taken into account here. Could you open a separate bug with some more information perhaps? I can try to look into it. |