Summary: | Installation might fail it user web doesn't have in its path the database command path | ||
---|---|---|---|
Product: | Koha | Reporter: | Salva Zaragoza Rubio <salva> |
Component: | Installation and upgrade (web-based installer) | Assignee: | Salva Zaragoza Rubio <salva> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | chris, gmcharlt, jcamins, m.de.rooy, paul.poulain |
Version: | 3.8 | ||
Hardware: | All | ||
OS: | Other | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Proposed patch to find the mysql/psql commands in Installer.pm with "which" and "whereis" before
Bug 6008 - Locating mysql/psql commands on Installer.pm |
Description
Salva Zaragoza Rubio
2011-03-30 16:13:42 UTC
Created attachment 3532 [details] [review] Proposed patch to find the mysql/psql commands in Installer.pm with "which" and "whereis" before Proposed patch to find the mysql/psql commands in Installer.pm with "which" and "whereis" before to allow the web user another chance to locate the database commands and execute them. Created attachment 7747 [details] [review] Bug 6008 - Locating mysql/psql commands on Installer.pm In Installer.pm when is looking for the system command to dump a file into the database it might fail if the web user doesn't have it in its path. So we add before a search with "which" and "whereis" commands, if they fail the command is itself without path. E.g.: with OpenBSD 4.8 the web user "www" doesn't have the path to the installed mysql bin: /usr/local/bin/mysql and fails in the web installer. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Seems to work fine, has a good default for if it fails to find that path This patch changes the mode of Installer.pm to 755. Please undo. QA comment * tiny patch in size * tested on my linux box, no visible change, worked before, work after. Will hopefully improve behaviour for OpenBSD There have been no further reports of problems so I am marking this bug resolved. |