Summary: | Log viewer needs permissions | ||
---|---|---|---|
Product: | Koha | Reporter: | Chris Cormack <chris> |
Component: | Transaction logs | Assignee: | Paul Poulain <paul.poulain> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | major | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | frederic.durand, januszop |
Version: | 3.4 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 5992 | ||
Attachments: |
Proposed Patch
A screenshot illustrating the problem |
Description
Chris Cormack
2011-03-30 22:11:12 UTC
Created attachment 3557 [details] [review] Proposed Patch It's ok, without reports permission no way to see the modification logs from the circulation menu. Pushed, please test This bug is mentioned in: Bug 6014 : MT3138 Adding some permission management to viewlog http://lists.koha-community.org/pipermail/koha-patches/2011-March/014382.html I believe this patch adds some enhancements (although since there is no detailed description I was unable to get the exact point), BUT it also introduces some problems. One is mentioned in Bug 6460. Another one is that apparently because of the changes made to vielog.tmpl (and, consequently, to viewlog.tt), the log generated from Tools --> Log viewer dialog (if it is generated at all--cf. Bug 6460), appears twice. Cf. attached screeshot from 3.2.9 (the same happens in 3.4.1). Because I am not aware what was the purpose for duplicating the whole part of vielog.tmpl which generates the log table I will not dare to touch it. So, please, could you review you patch...? Thank you in advance. Janusz Created attachment 4383 [details]
A screenshot illustrating the problem
Logs are no longer duplicated. Marking this bug resolved. |