Bug 6041

Summary: Errors from _koha_modify_item are ignored in ModItem (C4/Items)
Product: Koha Reporter: Marcel de Rooy <m.de.rooy>
Component: CatalogingAssignee: Galen Charlton <gmcharlt>
Status: RESOLVED INVALID QA Contact: Bugs List <koha-bugs>
Severity: normal    
Priority: P5 - low CC: koha.sekjal
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6852
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:

Description Marcel de Rooy 2011-04-04 08:25:16 UTC
# FIXME add checks
    # duplicate barcode
    # attempt to change itemnumber
    # attempt to change biblionumber (if we want
    # an API to relink an item to a different bib,
    # it should be a separate function)

    # update items table
    _koha_modify_item($item);

As seen above, the error from this subroutine is just ignored. This may well be a sql error; the record is not saved and the user is not warned. 

Actual example of this problem: see under bug 5839.
Comment 1 Marcel de Rooy 2013-06-06 13:02:37 UTC
Still the case in current master.
Comment 2 Marcel de Rooy 2016-09-08 10:15:29 UTC
Similar comment can be made for _koha_new_item in AddItem.
See bug 6852 that may present a fix for the new item case.
Comment 3 Katrin Fischer 2023-08-04 20:17:13 UTC
There is no ModItem anymore (bug 23463)
Comment 4 Katrin Fischer 2023-08-04 20:18:00 UTC
(In reply to Katrin Fischer from comment #3)
> There is no ModItem anymore (bug 23463)

Nor a _koha_modify_item