Summary: | Multiple level budget list on suggestions | ||
---|---|---|---|
Product: | Koha | Reporter: | Paul Poulain <paul.poulain> |
Component: | Acquisitions | Assignee: | Christophe Croullebois <christophe.croullebois> |
Status: | Failed QA --- | QA Contact: | Bugs List <koha-bugs> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | black23, jonathan.druart, marjorie.barry-vila, veron |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5963 | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | |||
Bug Blocks: | 34483 | ||
Attachments: |
proposed patch
proposed patch for T::TT proposed patch (taking care of Jonathan comment) proposed patch (taking care of jonathan comment, wrong upload a few mn ago) |
Description
Paul Poulain
2011-04-05 14:23:01 UTC
Created attachment 3697 [details] [review] proposed patch Katrin notices that the behaviour is fine BUT : * it would be great to have it on neworderempty too * it's inconsistent with what has been done for 5953 : (the "show all" button) we can't have show all and multiple level * the "show all button" is probably a bad idea = if a budget is inactive, it means we don't want to order on it anymore, so why would we have the opportunity to "show all" ? Speaking of it some minutes, we agree that : * the suggestion page MUST present all budgets and COULD present "my" budgets * the new order page MUST present my budgets It means an improvement could be done on both pages : * suggestion : let the user click on "my budgets" to see only his budgets (in a single dropdown list) or "all budget" with this 3 level behaviour * neworderempty : just keep "my" budget, but, if "I" have more than, for example 10 budgets, have a 3 level dropdown list. The patch works great and I really like the new display because it makes the different levels in budgets and funds visible instead of showing a flat list. The problem I see is, that the display is limited to 3 levels only. It is possible to create as many levels as you want - but only 3 levels can be displayed with this option. This means a library having created more then 3 levels (budget-fund-fund-...) will not be able to choose a fund on the 4th level in suggestions, because it will not be displayed. Created attachment 4797 [details] [review] proposed patch for T::TT Patch updated for Template::Toolkit & rebased against current master To answer Katrin comment = the 3 levels (that are 3 funds level, so budget-fund-fund-fund) is enough I think. use case: the librarian dealing with suggestions can (not must) choose a budget that will help the librarian managing acquisition to know this suggestion is for him. It means you don't need to choose the exact budget, you just reduce the number by choosing a part of your budget hierarchy. For example = You can choose "history" and let the librarian doing orders choosing between the sub budgets "european history" and "asian history" for example. Switching back this patch to "Needs signoff", thanks for your feedback The proposed patch works well for me. But i don't signed off : in suggestion/suggestion.pl we passed 2 times 'budgetsloop' to the tmpl : $template->param( budgetsloop => $budgets); $template->param( budgetsloop => $bud ); I think it's possible to delete the call to GetBudgets (l. 296). Created attachment 4858 [details] [review] proposed patch (taking care of Jonathan comment) well spotted Jonathan. I've removed the suggested lines, tested, still works Created attachment 4859 [details] [review] proposed patch (taking care of jonathan comment, wrong upload a few mn ago) Failed QA: If you edit the suggestion, select are not set with the good informations. "Any" are always selected. - patch does not apply - ist this bug still valid? I believe we should replace this with the funds list that has hierarchy levels etc as we have it on the receive screen. We should use that everywhere. |