| Summary: | Acquisition permissions inconsistencies | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Paul Poulain <paul.poulain> |
| Component: | Acquisitions | Assignee: | Paul Poulain <paul.poulain> |
| Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
| Severity: | minor | ||
| Priority: | PATCH-Sent (DO NOT USE) | CC: | chris |
| Version: | 3.4 | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
proposed patch
proposed patch (updated) Signed off patch |
||
Created attachment 3711 [details] [review] proposed patch Created attachment 3712 [details] [review] proposed patch (updated) * booksellers page = accessible to anyone that has at least 1 acq permission, but modifying accessible only if vendor_manage OK Possible enhancement: To get to suppliers detail page I have to search for booksellers. On the list following links are not hidden although I miss the permission: - modify - receive shipment * supplier detail = accessible to anyone that has at least 1 acq OK Possible enhancement: On booksellers detail the pulldown 'manage orders' should be hidden when I am missing permissions too. With vendor_manage I get to see 'Contracts' and 'New contract' but can't access them. Should be hidden, unless I have manage_contracts permission. Parcels only accesible with order_receive permission OK The patch works so I will signoff on it. The display could be improved to reflect the permissions of the user. Created attachment 3725 [details] [review] Signed off patch Pushed please test There have been no further reports of problems so I am marking this bug resolved. |
In large libraries, some librarian may have permission only to recieve shipments This patch fixes some permission : * booksellers page = accessible to anyone that has at least 1 acq permission * parcels = accessible to anyone with order_recieve * supplier detail = accessible to anyone that has at least 1 acq permission, but modifying accessible only if vendor_manage