Summary: | Missing translation markers in javascript alert messages | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | I18N/L10N | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | normal | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | chris |
Version: | 3.4 | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Initial patch
Follow up Signed off patch 1 Signed off patch 2 [3.2.x] fix |
Description
Katrin Fischer
2011-04-06 12:00:32 UTC
Created attachment 3761 [details] [review] Initial patch I ommited commented lines and "if $debug" lines too. Created attachment 3762 [details] [review] Follow up grep -R 'alert("' * was not enough. I needed grep -R "alert('" too!. Tested this patches and signed off on them. One of the changes was made to a file in the js directory - it will not break anything, but will not work either. Tose files are not included into the translation process. koha-tmpl/intranet-tmpl/prog/en/js/xmlControlfield.js @Tomas: Don't forget to add the bug number to your commit messages! :) Created attachment 3769 [details] [review] Signed off patch 1 Created attachment 3770 [details] [review] Signed off patch 2 Pushed, please test Created attachment 3936 [details] [review] [3.2.x] fix |