Summary: | adding a dynamic filter to pending holds | ||
---|---|---|---|
Product: | Koha | Reporter: | Alex Arnaud <alex.arnaud> |
Component: | Circulation | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | minor | ||
Priority: | P3 | CC: | chris, gmcharlt, jonathan.druart, koha.sekjal, paul.poulain |
Version: | 3.8 | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
The patch
screenshot of the result A new patch [SIGNED-OFF] Bug 6086 - adding a dynamic filter to pending holds Bug 6086 Followup Replace \t characters with 4 spaces |
Description
Alex Arnaud
2011-04-06 12:46:30 UTC
Updating to bug fix because when the list of pending is too long this is a nightmare to find a or some spécific(s) item(s). Created attachment 3744 [details] [review] The patch Hmm whats with the changes to a jquery file? Created attachment 4918 [details]
screenshot of the result
QA comment
This patch add a feature to have a filter on each table column.
For long tables, it's very handy.
However, this add a new jquery plugin, and we now have many. I'll sent a mail to koha-devel to get ppl opinion: which plugins do we need, which do we have,...
Note that this patch does not apply as it is for H:T (should be easy to port to T:T, but want ppl opinion before)
This patch no longer applies, and the new JQuery filter used needs some community feedback. Marking as Failed QA until these issues are resolved. i have to wait for a complet integration of datatable plugin before remake this patch. Created attachment 7989 [details] [review] A new patch Here is a new patch that take in account the new template system and the integration of datatables plugin. I have deleted all code related to server-side pagination. Tested with 9k rows sent to the page: it's ok. Created attachment 8038 [details] [review] [SIGNED-OFF] Bug 6086 - adding a dynamic filter to pending holds Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 8080 [details] [review] Bug 6086 Followup Replace \t characters with 4 spaces Marked as Passed QA. But Alex, could you set your editor to use spaces instead of tabulation ? Patch pushed BUT = can you note somewhere the [HTML4] coding guideline that says that "Hold To Pull" should be written "Hold to pull" (capital only on the 1st word). It was wrong before your patch, but you could have fixed it. |