Bug 6091

Summary:	Remove undeclared syspref OPACAdvSearchInputCount
Product:	Koha	Reporter:	Fridolin Somers <fridolin.somers>
Component:	Searching	Assignee:	Galen Charlton <gmcharlt>
Status:	CLOSED FIXED	QA Contact:	Bugs List <koha-bugs>
Severity:	minor
Priority:	P5 - low	CC:	chris, f.demians, koha.sekjal
Version:	3.4
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	---
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:
Circulation function:
Attachments:	Proposed patch

Description Fridolin Somers 2011-04-06 14:03:09 UTC

In advanced search pages :
catalogue/search.pl
opac/opac-search.pl

A syspref "OPACAdvSearchInputCount" is called to get number of input boxes to display. If syspref is false, there will be 3.

This syspref is not declared in administration, .pref files, nor in database installers.

I propose to simply remove this syspref call, input boxes number doesn't need a syspref since user can create new ones.

Regards,

Comment 1 Fridolin Somers 2011-04-06 14:08:08 UTC

Created attachment 3747 [details] [review]
Proposed patch

Comment 2 Ian Walls 2011-05-25 15:41:25 UTC

Covers all instances of this undefined system preference being called.  Better to remove these stubs, in my opinion, then add yet another system preference for what may not be a terribly desirable feature.

Marking as Passed QA.

Comment 3 Chris Cormack 2011-05-28 07:07:02 UTC

Pushed please test