Summary: | 'More options' in advanced search broken | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Templates | Assignee: | Colin Campbell <colin.campbell> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | normal | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, colin.campbell, magnus, nengard |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 5917 | ||
Attachments: |
Proposed patch for 3.2 and master
Proposed Patch (opac) Proposed Patch (Intranet) Signed off - 3895: Proposed patch for 3.2 and master Signed off: 3898: Proposed Patch (opac) Signed off: 3899: Proposed Patch (Intranet) screenshot of new box surrounding search options in staff Follow-up fix for layout issues Signed-off follow-up patch for layout issues |
Description
Katrin Fischer
2011-04-11 21:01:22 UTC
Not a template-toolkit driven bug. Can reproduce it on the 3.2.x branch If OPACGroupResults option is set the scripts logic to select a template is short circuited and we go to opac-grouped-results not advsearch. Created attachment 3895 [details] [review] Proposed patch for 3.2 and master Problem with grouped results hiding advanced search fix relevant to both master and 3.2 Created attachment 3898 [details] [review] Proposed Patch (opac) Created attachment 3899 [details] [review] Proposed Patch (Intranet) Not 100% sure that this addresses the layout issue. Can you test the patch and comment Created attachment 3901 [details] [review] Signed off - 3895: Proposed patch for 3.2 and master Created attachment 3902 [details] [review] Signed off: 3898: Proposed Patch (opac) Created attachment 3903 [details] [review] Signed off: 3899: Proposed Patch (Intranet) Created attachment 3904 [details]
screenshot of new box surrounding search options in staff
I signed off on the patches:
- the desciption is fixed
- the more/fewer links work now
- changing the syspref for opacgroupedresults didn't change that
I still see a problem with the layout in staff. There is an additional box surrounding each search option, that takes a more space than before and has a border line.
Patches pushed Should something be done about the layout, or can this bug be marked as fixed? Created attachment 4127 [details] [review] Follow-up fix for layout issues Simplifying markup in the staff client advanced search: - Moving IDs to fieldsets and removing redundant divs - Removing unused section - Adding missing IDs and fieldsets Created attachment 4180 [details] [review] Signed-off follow-up patch for layout issues Pushed the follow up |