Summary: | BibTeX export does not incude MARC21 main entry | ||
---|---|---|---|
Product: | Koha | Reporter: | Jared Camins-Esakov <jcamins> |
Component: | MARC Bibliographic data support | Assignee: | Eric Bégin <eric.begin> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | normal | ||
Priority: | P5 - low | CC: | bargioni, gitbot, gmcharlt, katrin.fischer, koha.sekjal, philippe.blouin, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10972 | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | 9274 | ||
Bug Blocks: | |||
Attachments: |
BibTeX export now includes MARC21 main entry
Fix marc2bibtex to consider fields 1xx on author. Add fields 1xxx to marc2bibtex Add fields 1xxx to marc2bibtex Bug 6201 - Add fields 1xx to marc2bibtex [PASSED QA] Bug 6201 - Add fields 1xx to marc2bibtex |
Description
Jared Camins-Esakov
2011-04-18 14:28:18 UTC
This bug is still present in master as of 3.12 beta1 Created attachment 21503 [details] [review] BibTeX export now includes MARC21 main entry Patch attached How to test : - Search any books in the OPAC with a main entry (1XX in MARC21, 700-720 in Unimarc) - Export the record in the bibtex format » The output won't contains the main entry. ---- Apply the patch - Export the record The output file will contain the main entry Created attachment 21504 [details] [review] Fix marc2bibtex to consider fields 1xx on author. Sponsored-by: Institut universitaire en santé mentale de Montréal Created attachment 21511 [details] [review] Add fields 1xxx to marc2bibtex Amended the last commit message to follow the standards. Redid the patch. Created attachment 21525 [details] [review] Add fields 1xxx to marc2bibtex Patch applied cleanly, go forth and signoff Created attachment 21571 [details] [review] Bug 6201 - Add fields 1xx to marc2bibtex Modified Record::marc2bibtex to varlidate fields 100,110 and 111 in non-Unimarc flavours. Test plan: 1)Search any books in the OPAC with a main entry (1XX in MARC21, 700-720 in Unimarc) 2)Export the record in the bibtex format ==>The output won't contains the main entry. 3)Apply the patch \n4)Export the record ==>The record will contain the main entry Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Comment on attachment 21571 [details] [review] Bug 6201 - Add fields 1xx to marc2bibtex Review of attachment 21571 [details] [review]: ----------------------------------------------------------------- ::: C4/Record.pm @@ +668,2 @@ > } > $author = join ' and ', @texauthors; This is an old line, but also a bug. We should never hardcode English strings in Perl modules. Never ever. Created attachment 21604 [details] [review] [PASSED QA] Bug 6201 - Add fields 1xx to marc2bibtex Modified Record::marc2bibtex to varlidate fields 100,110 and 111 in non-Unimarc flavours. Test plan: 1)Search any books in the OPAC with a main entry (1XX in MARC21, 700-720 in Unimarc) 2)Export the record in the bibtex format ==>The output won't contains the main entry. 3)Apply the patch 4)Export the record ==>The record will contain the main entry Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Fixes a long standing bug. Passes all tests and QA script. Tested with multiple records, seems to work well. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
> > $author = join ' and ', @texauthors;
>
> This is an old line, but also a bug. We should never hardcode English
> strings in Perl modules. Never ever.
From what I know, the 'and' is part of the bibtex standard and is language agnostic.
Hm, weird format:) Pushed to master. Thanks, Philippe! Also, looks like this is your first patch accepted into Koha. Congratulations! This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Philippe and congratulations! |