| Summary: | Staff client search results template error | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Searching | Assignee: | Galen Charlton <gmcharlt> |
| Status: | CLOSED WORKSFORME | QA Contact: | Bugs List <koha-bugs> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | chris |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 5917 | ||
|
Description
Owen Leonard
2011-04-20 13:08:39 UTC
Yes , is not part of a valid variable name in perl The code should have been changed accordingly I will check if ($indexes[0] && (!$indexes[1] || $params->{'scan'})) {
my $idx = "ms_".$indexes[0];
$idx =~ s/\,/comma/g; # template toolkit doesnt like variables with a , in it
$template->param($idx => 1);
}
Yep looks ok to me, is the results page actually erroring owen, cos im thinking of marking this works for me
I found the problem by searching for instances of "comma" based on other template errors. Judging from the template, it's part of the "Scan indexes" functionality, something I don't use or understand. There's no error in standard operation. Yeah its fixed in the perl, its setting the variables to match what is in the template, so i think tis all good |