Bug 6237

Summary: Recent changes leave compile time warnings in additem.pl
Product: Koha Reporter: Colin Campbell <colin.campbell>
Component: Architecture, internals, and plumbingAssignee: Colin Campbell <colin.campbell>
Status: CLOSED FIXED QA Contact: Bugs List <koha-bugs>
Severity: normal    
Priority: PATCH-Sent (DO NOT USE) CC: chris
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Proposed Patch
Proposed patch for C4::Auth

Description Colin Campbell 2011-04-21 15:04:08 UTC
After recent changes additem.pl a couple of compile time warnings have crept into cataloguing/additem.pl due to global variables being declared in two places. Remove the duplicates. Additem is also showing a compile time error from C4::Auth due to a line which serves no purpose in there
Comment 1 Colin Campbell 2011-04-21 15:14:57 UTC
Created attachment 3970 [details] [review]
Proposed Patch
Comment 2 Colin Campbell 2011-04-21 15:15:44 UTC
Created attachment 3971 [details] [review]
Proposed patch for C4::Auth
Comment 3 Chris Cormack 2011-04-21 19:32:02 UTC
THanks for the catch Colin. Pushed
Comment 4 Katrin Fischer 2011-04-25 17:12:06 UTC
How to test that? Add items and check the logs for entries?
Comment 5 Colin Campbell 2011-04-26 13:04:15 UTC
Test with perl -wc additem.pl run the compile pass on the script with warnings enabled
Comment 6 Jared Camins-Esakov 2012-12-31 00:14:23 UTC
There have been no further reports of problems so I am marking this bug resolved.