| Summary: | AllowHoldPolicyOverride ON causes every staff hold to require override | ||
|---|---|---|---|
| Product: | Koha | Reporter: | D Ruth Holloway <ruth> |
| Component: | Hold requests | Assignee: | Ian Walls <koha.sekjal> |
| Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
| Severity: | enhancement | ||
| Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, gmcharlt, nengard, robin |
| Version: | 3.6 | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
Pushed, please test Tested, works on both master and 3.4.x To clarify, afaik it hasn't been pulled into 3.4.x, but it should be and it works there. |
if AllowHoldPolicyOverride is turned on, any attempt in the staff client to place a hold will require override, even if it should not. Turning the syspref OFF lets normal rules take over. In reserve/request.pl, right after the comment " If AllowHoldPolicyOverride is set, it should override EVERY..." (circa line 444-450) seems to be the crux of the matter. It should, I suspect, check to see if item->{available} is already *set* before setting $item->{override}.