Summary: | Add {BIBLIONUMBER} parsing support to SearchForTitleIn syspref | ||
---|---|---|---|
Product: | Koha | Reporter: | Ian Walls <koha.sekjal> |
Component: | OPAC | Assignee: | Ian Walls <koha.sekjal> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | enhancement | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, nengard |
Version: | 3.6 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | Sponsored | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: | signed off patch |
Description
Ian Walls
2011-05-03 15:30:28 UTC
Whoops, my mistake... </ul> must be added to make this work: Revised sample code: </ul></div></div><div class="detailtagcell"> <script src="http://connect.facebook.net/en_US/all.js#xfbml=1"></script><fb:like href="http://opac.mylibrary.tld/bib/{BIBLIONUMBER}" show_faces="true" width="450" font=""></fb:like> <div><a href="http://twitter.com/share" class="twitter-share-button" data-url="http://opac.mylibrary.tld/bib/{BIBLIONUMBER}" data-text="I'm reading this" data-count="horizontal">Tweet</a><script type="text/javascript" src="http://platform.twitter.com/widgets.js"></script></div></div><div><div><ul> Created attachment 4032 [details] [review] signed off patch Patch itself passes QA. Particular applications, like Facebook 'like' links and such may still require refinement, but are outside the immediate scope of this enhancement (which is just the parsing of {BIBLIONUMBER}). Tested with NULL and incorrect biblionumber values in the URL; 404 page returns as expected. Pushed, please test opac-MARCdetail.pl and opac-ISBDdetail also need a fix. I tried- but I need more than copy paste to make it work - so it's on Ian to update. This appears to be working. Closing. |