Summary: | Batch progress bar does not check for 0 size jobs; should be in separate js too | ||
---|---|---|---|
Product: | Koha | Reporter: | Srdjan Jankovic <srdjan> |
Component: | Tools | Assignee: | Srdjan Jankovic <srdjan> |
Status: | CLOSED FIXED | QA Contact: | Jonathan Druart <jonathan.druart> |
Severity: | minor | ||
Priority: | P5 - low | CC: | chris, jcamins, jonathan.druart, koha.sekjal, paul.poulain, wizzyrea |
Version: | 3.8 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
p
patch bug 6372: moved background-job.inc to background-job-progressbar.js patch bug 6372: moved background-job.inc to background-job-progressbar.js |
Description
Srdjan Jankovic
2011-05-19 07:09:52 UTC
Created attachment 4183 [details] [review] p Created attachment 7607 [details] [review] patch Not sure why it did not apply. Rebased without any problems. Created attachment 8144 [details] [review] bug 6372: moved background-job.inc to background-job-progressbar.js Check for div 0 when calculating percentage. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> The batch item modification tool now handles zero-size batches properly, and staging MARC records still works. Scanning for remaining instances of [% INCLUDE 'background-job.inc' %], I found one left in: koha-tmpl/intranet-tmpl/prog/en/modules/tools/upload-images.tt Created attachment 8549 [details] [review] patch Yes, that came in after the patch with Bug 1633 Created attachment 9076 [details] [review] bug 6372: moved background-job.inc to background-job-progressbar.js Check for div 0 when calculating percentage Signed-off-by: Liz Rea <wizzyrea@gmail.com> div0 no longer appears on 0 size jobs. Passes t xt QA comment: - Move background job javascript code into a js file. - Delete useless routine progress_callback (batchmod.pl) - Fix the specific case where there is no job to process Marked as Passed QA Patch pushed. I've tested that Koha still works with files that are not of size 0 Note that it's hard to spot the div by 0 in the midlde of the move to .js. Both are perfect things, but it would have been better to do 2 patches |