Summary: | Record local use stats when checking in | ||
---|---|---|---|
Product: | Koha | Reporter: | Ian Walls <koha.sekjal> |
Component: | Circulation | Assignee: | Ian Walls <koha.sekjal> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | enhancement | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, gmcharlt, nengard, paul.poulain |
Version: | 3.6 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | Sponsored | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Proposed patch (functionality)
Proposed Patch (DB changes) Proposed Patch (DB changes) [SIGNED-OFF] Enh 6403: Record local use stats when checking in unissued materials [SIGNED-OFF] Enh 6403 DB changes: add RecordLocalUseOnReturn syspref |
Description
Ian Walls
2011-05-24 16:42:01 UTC
Created attachment 5549 [details] [review] Proposed patch (functionality) Adds option to count returns as 'local use' for non-issued items in statistical logs. Created attachment 5550 [details] [review] Proposed Patch (DB changes) Adds new system preference to sysprefs.sql and updatedatabase.pl Created attachment 5587 [details] [review] Proposed Patch (DB changes) Created attachment 5588 [details] [review] [SIGNED-OFF] Enh 6403: Record local use stats when checking in unissued materials Adds a new system preference, RecordLocalUseOnReturn, which when active will change the statistical entry type from "return" to "localuse" in AddReturn() if the material was not on loan when returned. The intended use-case here is for libraries with 'open' book drops, in which patrons can put locally used (but unissued) materials. Adds a small message to the user interface to confirm that Local Use was recorded. This change opens up the possibility to record more types of statistics on return; one would just need to update the $stat_type variable accordingly. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Created attachment 5589 [details] [review] [SIGNED-OFF] Enh 6403 DB changes: add RecordLocalUseOnReturn syspref This patch, separate from the main functionality patch, adds the new syspref to the sysprefs.sql as well as updatedatabase.pl Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> QA comment * good test plan * works as expected * nothing to say about the code itself My only comment could be that some libraries consider saving such returns as a bug, so we could set the default value of the new syspref to 1 directly. But we've a rule to say a new syspref sould not change the behaviour for libraries that don't do anything with it. SO : * passed QA * it's worth being very clear in the release note that most libraries will probably want to set this value to 1 after upgrading Pushed, please test This appears to be working. Closing. |