| Summary: | Messaging not showing on patron categories | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
| Severity: | normal | ||
| Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, koha.sekjal |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 6408 | ||
| Bug Blocks: | 5917 | ||
| Attachments: |
no messaging showing on patron categories
Screenshot of the proposed revised interface Proposed fix |
||
marked as depends on 6408 because the screenshot i attached is after applying the patch for 6408 Created attachment 4633 [details]
Screenshot of the proposed revised interface
Created attachment 4634 [details] [review] Proposed fix T:T variable name problems were causing the problem. I used this opportunity to change the way the data is output: Now the messaging preferences are only output if there is a current setting. Also corrected the js table sorter configuration for the right columns and moved the template-based table row striping to the tablesorter plugin config. Template only change, easy to read, marking as Passed QA Pushed, please test |
Created attachment 4287 [details] no messaging showing on patron categories On the patron category form the messages always say unknown even if a message is selected and saved. When you click edit, you see the messaging preferences were saved. Also the sorting is on the edit/delete column instead of the messaging column - see attached.