Bug 6459

Summary: Needless call to C4::Context->dbh in C4::Templates::themelanguage()
Product: Koha Reporter: Magnus Enger <magnus>
Component: TemplatesAssignee: Magnus Enger <magnus>
Status: CLOSED FIXED QA Contact: Bugs List <koha-bugs>
Severity: trivial    
Priority: PATCH-Sent (DO NOT USE) CC: chris
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Proposed patch
Bug 6459 : Needless call to C4::Context->dbh in C4::Templates::themelanguage()

Description Magnus Enger 2011-06-04 17:49:15 UTC
As far as I can see, line 194 in C4::Templates::themelanguage() is not needed: 

my $dbh = C4::Context->dbh;

$dbh does not seem to be used again in the scope in which it is created. 

Patch coming up.
Comment 1 Magnus Enger 2011-06-04 17:53:59 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2011-06-06 20:26:13 UTC
Created attachment 4385 [details] [review]
Bug 6459 : Needless call to C4::Context->dbh in C4::Templates::themelanguage()

As far as I can tell, $dbh is never used again in the scope in which it is
created. This patch simply removes the line.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Comment 3 Chris Cormack 2011-06-06 20:26:40 UTC
Yep, it is a needless call, signed off
Comment 4 Chris Cormack 2011-06-09 23:21:48 UTC
And pushed to master