| Summary: | column sorter on holds queue | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
| Component: | Templates | Assignee: | Ian Walls <koha.sekjal> |
| Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
| Severity: | enhancement | ||
| Priority: | PATCH-Sent (DO NOT USE) | CC: | paul.poulain |
| Version: | 3.6 | ||
| Hardware: | All | ||
| OS: | All | ||
| URL: | cgi-bin/koha/circ/view_holdsqueue.pl | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Proposed Patch
[SIGNED-OFF] Bug 6471: add tablesorter to Holds Queue Bug 6471: add tablesorter to Holds Queue |
||
|
Description
Nicole C. Engard
2011-06-06 19:35:16 UTC
Created attachment 5475 [details] [review] Proposed Patch Adds tablesort to all columns of Holds Queue report Created attachment 5476 [details] [review] [SIGNED-OFF] Bug 6471: add tablesorter to Holds Queue This patch adds the table sorter to Holds Queue. Sponsored by Farmington Public Library. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Created attachment 5773 [details] [review] Bug 6471: add tablesorter to Holds Queue This patch adds the table sorter to Holds Queue. Sponsored by Farmington Public Library. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> QA comment: * small patch, affecting only templates * good description * good code Passed QA Note that the tablesorter was added at an earlier time and then removed: http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=dee5f4945b645bbd314602479f990a08a896370c "As part of this patch, commented out the JavaScript tablesorter, which could cause the browerer to lock up if the picklist contains more than a couple hundred items to pull." (In reply to comment #5) > "As part of this patch, commented out the JavaScript tablesorter, > which could cause the browerer to lock up if the picklist > contains more than a couple hundred items to pull." I thought of this case (forgot to add it to my QA comment), but was thinking there was never more than hundred items to pull (otherwise, it means the library should check more frequently the list !) on a 10 branches library, 100 every day means 300 000 items to pull per year, that's more than huge according to me ! patch pushed, please test Included in 3.6 prior to 3.6.5. |