Summary: | Variable $sth is declared 3 times (with keyword "my") in "makepayment" sub of "Accounts.pm" | ||
---|---|---|---|
Product: | Koha | Reporter: | Ricardo Dias Marques <ricmarques> |
Component: | Patrons | Assignee: | Kyle M Hall <kyle.m.hall> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | minor | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, colin.campbell, gmcharlt, koha.sekjal, ricmarques |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Patch to fix Bug 6503
Bug 6503 - Variable $sth is declared 3 times (with keyword "my") in "makepayment" sub of "Accounts.pm" |
Description
Ricardo Dias Marques
2011-06-14 15:59:22 UTC
Created attachment 4453 [details] Patch to fix Bug 6503 Proposed patch in the above link to fix this bug 6503. Created attachment 4467 [details] [review] Bug 6503 - Variable $sth is declared 3 times (with keyword "my") in "makepayment" sub of "Accounts.pm" In the code available today (14-Jun-2011), in Koha git's "master" branch, the file "Accounts.pm" (in the "C4" directory) has the variable "$sth" declared 3 times in the "makepayment" sub. This causes the following warnings to appear when running "make test" in Koha installation, for several tests: t/Heading.t ......................... "my" variable $sth masks earlier declaration in same scope at kohaclone/blib/PERL_MODULE_DIR/C4/Accounts.pm line 172. "my" variable $sth masks earlier declaration in same scope at kohaclone/blib/PERL_MODULE_DIR/C4/Accounts.pm line 188. [...] t/ILSDI_Services.t .................. "my" variable $sth masks earlier declaration in same scope at kohaclone/blib/PERL_MODULE_DIR/C4/Accounts.pm line 172. "my" variable $sth masks earlier declaration in same scope at kohaclone/blib/PERL_MODULE_DIR/C4/Accounts.pm line 188. [...etc...] Therefore, I'm removing the "my" keyword from the declarations of "$sth" in lines 172 and 188 of "Accounts.pm". Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Simple change, easy to read, marking as Passed QA Pushed, please test *** Bug 6469 has been marked as a duplicate of this bug. *** There have been no further reports of problems so I am marking this bug resolved. |