| Summary: | Add ids to divs in opac-reserve.tt | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Ian Walls <koha.sekjal> |
| Component: | OPAC | Assignee: | Ian Walls <koha.sekjal> |
| Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
| Severity: | enhancement | ||
| Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, nengard |
| Version: | 3.6 | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | Sponsored | Crowdfunding goal: | 0 |
| Patch complexity: | --- | Documentation contact: | |
| Documentation submission: | Text to go in the release notes: | ||
| Version(s) released in: | Circulation function: | ||
| Attachments: | patch | ||
Created attachment 4740 [details] [review] patch Simple html changes, pushing Patch is pushed and working, closing bug. |
Error messages in the OPAC reserves tool need to include unique IDs so the text can be easily customized with JQuery. Work To Be Done: * Add id attributes to all id-less div tags containing holds error messages, including: o too_much_oweing o too_many_reserves o bad_biblionumber o no_items_selected o no_branch_selected o no_biblionumber o bad_data o none_available How to test: * Create a test patron * For each message, supply the necessary criteria to trigger it. Attempt to place a hold... -- too_much_oweing: ...when the test patron owes too many fines, as per system preferences -- too_many_reserves: ...whenthe test patron already has more reserves than allowed by circulation rules -- bad_biblionumber: ...on a biblio that doesn’t exist -- no_items_selected: ...when no items are selected -- no_branch_selected: ...without selecting a pickup branch -- no_biblionumber: ...without supplying any biblionumber -- bad_data: ...on multiple titles, without supplying either a biblionumber, itemnumber or branchcode for each title -- none_available: ...on a title with no available items * If the HTML source of the page includes an id for each div tag that wraps the error message, then the test is passed.