Summary: | applying lending rules by item-level itypes | ||
---|---|---|---|
Product: | Koha | Reporter: | Justin @ Prosentient <prosentientsystems> |
Component: | Hold requests | Assignee: | Justin @ Prosentient <prosentientsystems> |
Status: | CLOSED DUPLICATE | QA Contact: | Bugs List <koha-bugs> |
Severity: | normal | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, dev_patches, gmcharlt, jcamins |
Version: | rel_3_2 | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
logic change using items.itype instead of biblio
Updated patch from git |
Description
Justin @ Prosentient
2011-07-04 01:13:14 UTC
Created attachment 4554 [details] [review] logic change using items.itype instead of biblio We don't have git set up just yet. As soon as we do we'll submit it through there. Created attachment 4557 [details] [review] Updated patch from git This replaces the previous patch we uploaded (since it's from the git and actually mentions the file we modified. Hi Justin Pretty close, but unfortunately this line here $select .= " LEFT JOIN itemtypes ON biblioitems.itype = Won't work, its biblioitems.itemtype Can you please fix and resend Thank you Chris Your patch is Bad. See http://wiki.koha-community.org/wiki/Coding_Guidelines Commiting Code Hi Justin I think what Biblibre were trying to say, is your patch needs a better commit message, plus the little issue I spotted fixed up. As this is you first patch, we are happy to help you sort through any issues, either catch us on irc, or update the bug if you have something you don't understand or need help with. We always want new committers, so are happy to help you get your patch into tip top shape. Chris |