| Summary: | only 10 lists in pull down when adding from a bib record | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
| Component: | Lists | Assignee: | Chris Cormack <chris> |
| Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
| Severity: | normal | ||
| Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, koha.sekjal |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| URL: | cgi-bin/koha/virtualshelves/addbybiblionumber.pl?biblionumber=3 | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
10 lists instead of 12 (or all)
Bug 6555 : only 10 lists show in the staff client [SIGNED-OFF] Bug 6555 : only 10 lists show in the staff client |
||
Works on OPAC, just not staff side, working on a fix now The problem comes from
else { # this shelf doesn't already exist.
my $limit = 10;
Then it calls GetRecentShelves
The opac, just calls GetAllShelves with no limit set
I can change the intranet to match, would having no limit be a worry to anyone?
If you didn't get all shelves, how would you add to shelves that aren't showing in the pull down - would you have to go to the list and add by barcode instead? I think if it works in the OPAC we should do the same in the staff client so that people can add to lists the same way in both places. I agree with Nicole that the behaviour should be consistent. A more robust solution would be YASP (yet another system preference) to control how many titles are shown on the list. Even more, we could have two, one for OPAC and one for staff client. Not recommending this, just pointing it out as an option. I don't think a system preference would be useful. The problem would remain: there wouldn't be any reasonable way for the user to add a title to one of the lists which wasn't shown. Righto, ill just make show all for now someone if they feel so moved can do an enchancement to make it show some and then have a show all button if they feel so moved. Created attachment 5303 [details] [review] Bug 6555 : only 10 lists show in the staff client this works, however there is still an issue on the search results in the staff client when adding to a list - but this bug didn't mention that. Created attachment 5319 [details] [review] [SIGNED-OFF] Bug 6555 : only 10 lists show in the staff client Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Mostly an SQL change, with some params called differently depending on context. Marking as Passed QA Pushed, please test The fix for this bug was published in the 3.4.5 release. If you were the reporter of this bug, please take time to verify the fix and update the status of this bug report accordingly. If the bug is fixed to your satisfaction, please close this report. There have been no further reports of problems so I am marking this bug resolved. |
Created attachment 4559 [details] 10 lists instead of 12 (or all) I have attached a screenshot of the problem. We currently have 12 public lists (and I have 1 private list) but when I try to add to a list from within a bib record in the staff client, I only get a list of 10...and of course the one I need (Educations & Licensure) is not on it.