Summary: | Calendar showing the wrong event type when editing | ||
---|---|---|---|
Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | normal | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, koha.sekjal |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
calendar showing diff info on right and left (the right is right)
Proposed fix Screenshot of the revised interface |
Created attachment 4630 [details] [review] Proposed fix This bug must have been present for a while. There wasn't proper handling of repeating yearly holidays when it came to the label. To be clear, I believe this bug only affected holidays which repeat yearly on the same date. Instead of correcting the label to match the existing scheme I added a new color code and label so that there are now two styles for yearly and weekly repeating holdiays. This makes it more clear what kind of repeating holiday you're looking at (rather than having one color code for both). After applying this patch, new and existing holidays which repeat yearly on the same day should be color-coded orange and have a 'Holiday repeating yearly' label. Weekly holidays are now labeled 'Holiday repeating weekly.' Created attachment 4631 [details]
Screenshot of the revised interface
Template only change, well documented, easy to see that it works. Marking as Passed QA Patch pushed, please test |
Created attachment 4625 [details] calendar showing diff info on right and left (the right is right) When you click to edit an event on the calendar it has the wrong event type on the left. See the image.