| Summary: | Javascript error in cloning subfields | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Justin @ Prosentient <prosentientsystems> |
| Component: | Cataloging | Assignee: | Justin @ Prosentient <prosentientsystems> |
| Status: | CLOSED WONTFIX | QA Contact: | Bugs List <koha-bugs> |
| Severity: | normal | ||
| Priority: | PATCH-Sent (DO NOT USE) | CC: | jcamins, koha.sekjal, m.de.rooy |
| Version: | rel_3_2 | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: | makes var buttonDotOnClick a String for IE7 | ||
|
Description
Justin @ Prosentient
2011-07-22 05:20:36 UTC
Created attachment 4709 [details]
makes var buttonDotOnClick a String for IE7
(In reply to comment #1) > Created attachment 4709 [details] > makes var buttonDotOnClick a String for IE7 I have a question about: var buttonDotOnClick = String(link.getAttribute('onclick')); Where did you define link in the Clonefield function? Why do you call String? Is it necessary to recover from a null? This may indeed be browser dependent. I tested your patch in IE8, but have to say that there are more JS errors while doing that. Our users are running staff in Firefox for that reason. I'm marking this Failed QA because of the questions raised above. Let's re-evaluate after that. Because this problem is with 3.2 which is no longer supported, and IE7 which is several versions out of date, I don't think anyone is going to pick this up again. If you are able to reproduce the problem with a current version of Koha and would like to submit a revised patch that addresses Marcel's concerns, please reopen the bug. |