Bug 6640

Summary: Template errors in defining default variable values causes information not to be displayed
Product: Koha Reporter: Nicole C. Engard <nengard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Bugs List <koha-bugs>
Severity: normal    
Priority: P5 - low CC: chris, kaust, koha.sekjal
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: Small patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: example
Proposed fix

Description Nicole C. Engard 2011-07-28 13:22:53 UTC
when you use the stats wizards for stats and look for stats on shelving locations the location names don't show on the screen (but there is a row for each). If you export the file to csv then the field names do show - so it sounds to me like a template/display issue.
Comment 1 Nicole C. Engard 2011-08-01 23:56:23 UTC
Created attachment 4806 [details]
example
Comment 2 Ian Walls 2011-08-02 11:01:25 UTC
Sounds like a Template::Toolkit scope issue...
Comment 3 Owen Leonard 2011-08-03 14:50:30 UTC
Created attachment 4828 [details] [review]
Proposed fix

An invalid template syntax for defining a variable's default
    value is found in the circ report template and several
    others:
    
    [% DEFAULT LibraryNameTitle="Koha Online" %]
    
    Based on the T:T docs this appears to be the correct way of defining
    a default value:
    
    [% LibraryNameTitle or "Koha Online" %]
    
    Reference:
    
    http://template-toolkit.org/docs/manual/Syntax.html#section_Implicit_Directives_GET_and_SET
Comment 4 Owen Leonard 2011-08-12 12:42:28 UTC
*** Bug 6493 has been marked as a duplicate of this bug. ***
Comment 5 Chris Cormack 2011-08-18 08:56:32 UTC
Patch pushed, please test
Comment 6 Chris Nighswonger 2011-10-26 18:02:08 UTC
The fix for this bug was published in the 3.4.5 release. If you were the reporter of this bug, please take time to verify the fix and update the status of this bug report accordingly. If the bug is fixed to your satisfaction, please close this report.