Bug 6691

Summary: Can't place hold even with override on
Product: Koha Reporter: Nicole C. Engard <nengard>
Component: Hold requestsAssignee: Jesse Weaver <pianohacker>
Status: CLOSED WORKSFORME QA Contact: Bugs List <koha-bugs>
Severity: normal    
Priority: P5 - low CC: gmcharlt, katrin.fischer
Version: master   
Hardware: All   
OS: All   
URL: cgi-bin/koha/reserve/request.pl?biblionumber=504
Change sponsored?: --- Patch complexity: ---
Who signed the patch off: Text to go in the release notes:
Version(s) released in:
Attachments: note 'undefined'

Description Nicole C. Engard 2011-08-09 20:57:25 UTC
Once again I think this is a T:T issue - if not please reassign.

When you're trying to place a hold on an item that isn't usually allowed to be put on hold (with override turned on and logged in as a superlibrarian) you get the usual errors but when you say you want to place the hold anyway nothing happens.  See attached and note this is with item specific holds.
Comment 1 Nicole C. Engard 2011-08-09 20:57:45 UTC
Created attachment 4915 [details]
note 'undefined'
Comment 2 Nicole C. Engard 2011-08-09 20:59:12 UTC
I lied, it's actually both item specific and next available that have this issue.
Comment 3 Nicole C. Engard 2011-08-09 21:13:31 UTC
This is also with allow on shelf holds turned off.

So you're allowing hold overrides but not on shelf holds - but can't seem to override on shelf hold rules anymore.
Comment 4 Katrin Fischer 2011-08-10 06:07:13 UTC
I have run into this problem during presentations - confirming Nicole's bug report.
Comment 5 Owen Leonard 2011-08-15 20:19:31 UTC
This is not a template bug (at least it's not related to the T:T upgrade). The same bug can be triggered in the html_template_pro branch. I'm reassigning to pianohacker in the hopes that he has some memory of the underlying code's creation.
Comment 6 Katrin Fischer 2012-03-19 07:11:43 UTC
Trying to place an item level hold on an item that is not available for a hold (AllowHoldPolicyOverride is activated).

When activating the checkbox, Koha asks:

Place hold on this item?

After confirmation nothing happens, but the checkbox is checked.

When clicking on the 'Place hold' button, Koha asks:

None of these items can normally be put on hold for this patron.

Place hold?

After confirming this second warning, the hold is placed.

Lowering severity as placing holds does work - perhaps we could get rid of one of the alerts?
Comment 7 Katrin Fischer 2015-06-06 21:37:04 UTC
This works ok on current master.