Summary: | Layout of patron category add/edit form slightly broken | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | trivial | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, koha.sekjal |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
URL: | /cgi-bin/koha/admin/categorie.pl?op=add_form&categorycode=TEST | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
screenshot
Proposed fix Screenshot of the revised interface [SIGNED-OFF] Fix for Bug 6695 - Layout of patron category add/edit form slightly broken |
Created attachment 4944 [details] [review] Proposed fix The markup for the fields for enrollment period "in months" and "until date" was non-standard I think because the two fields are supposed to be visually and functionally linked (having the same purpose and being mutually exclusive). This patch changes the markup so that the two fields share a fieldset having "choose one" as the legend. The "hint" is now hidden unless it is triggered by the javascript validation on submit. I wanted to trigger the validation of the two fields onblur instead of just onsubmit, but found that the datepicker widget doesn't consistently trigger a change or a blur event on that field. Created attachment 4946 [details]
Screenshot of the revised interface
Created attachment 4970 [details] [review] [SIGNED-OFF] Fix for Bug 6695 - Layout of patron category add/edit form slightly broken The markup for the fields for enrollment period "in months" and "until date" was non-standard I think because the two fields are supposed to be visually and functionally linked (having the same purpose and being mutually exclusive). This patch changes the markup so that the two fields share a fieldset having "choose one" as the legend. The "hint" is now hidden unless it is triggered by the javascript validation on submit. I wanted to trigger the validation of the two fields onblur instead of just onsubmit, but found that the datepicker widget doesn't consistently trigger a change or a blur event on that field. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> - Layout problems are fixed - Layout is more clear about choosing either 'In months' or 'Until date' - Clear error message shows when you enter values in both fields Template only change, easy to read, well tested, marking as Passed QA Pushed, please test The fix for this bug was published in the 3.4.5 release. If you were the reporter of this bug, please take time to verify the fix and update the status of this bug report accordingly. If the bug is fixed to your satisfaction, please close this report. There have been no further reports of problems so I am marking this bug resolved. |
Created attachment 4922 [details] screenshot Fields are not beginning in one line and 'Until:' shows up under 'months'.