Summary: | Better handling of version numbers in updatedatabase | ||
---|---|---|---|
Product: | Koha | Reporter: | Marcel de Rooy <m.de.rooy> |
Component: | Installation and upgrade (web-based installer) | Assignee: | Marcel de Rooy <m.de.rooy> |
Status: | CLOSED FIXED | QA Contact: | Jonathan Druart <jonathan.druart> |
Severity: | normal | ||
Priority: | P3 | CC: | gmcharlt, jonathan.druart, julian.maurice, paul.poulain |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Signed patch of Chris (test for XXX version)
Patch for updatedatabase Signed off patch for updatedatabase Signed patch of Chris (test for XXX version) Signed patch of Chris (test for XXX version) |
Description
Marcel de Rooy
2011-08-10 14:35:08 UTC
Created attachment 4939 [details] [review] Signed patch of Chris (test for XXX version) Created attachment 4942 [details] [review] Patch for updatedatabase Please note: This second patch still needs a signoff. Created attachment 6183 [details] [review] Signed off patch for updatedatabase It works as expected: launching manually updatedatabase.pl causes the update for version XXX to be executed, and the Version syspref is not touched. And the installer is not launched when going to professional interface. Signed off QA comment: there are 3 patches attached, it's not clear to me what must be applied... I think there are 2: the 4939 and 6183 Julian, could you confirm you've forgotten to obsolete 4942 when signing-off and uploading 6183 ? (In reply to comment #4) > QA comment: there are 3 patches attached, it's not clear to me what must be > applied... > I think there are 2: the 4939 and 6183 > Julian, could you confirm you've forgotten to obsolete 4942 when signing-off > and uploading 6183 ? I obsoleted the proposed second patch; so two signed patches remain. (In reply to comment #4) > QA comment: there are 3 patches attached, it's not clear to me what must be > applied... > I think there are 2: the 4939 and 6183 > Julian, could you confirm you've forgotten to obsolete 4942 when signing-off > and uploading 6183 ? Yes, 6183 is the signed-off version of 4942 Passed QA for "Signed off patch for updatedatabase". But t/00-checkdatabase-version.t test match pattern 'XXX' in updatedatabase.pl and this file always contains it (in functions TransformToNum and SetVersion) Maybe we want match /^$DBversion.*XXX/ Created attachment 6868 [details] [review] Signed patch of Chris (test for XXX version) Amended patch of Chris for the two exceptions mentioned by Jonathan in QA. Created attachment 6869 [details] [review] Signed patch of Chris (test for XXX version) Oops wrong file.. Passed QA Patch pushed, please test |