Bug 6701

Summary: language on timeout system preference is wrong
Product: Koha Reporter: Nicole C. Engard <nengard>
Component: TemplatesAssignee: Dobrica Pavlinusic <dpavlin>
Status: CLOSED FIXED QA Contact: Bugs List <koha-bugs>
Severity: normal    
Priority: P5 - low CC: chris, cnighswonger, dpavlin, koha.sekjal, mjr, paul.poulain
Version: 3.6   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: bug 6701 - change timeout to say milliseconds
bug 6701 - change timeout to say milliseconds
Bug 6701 - login timeout is in seconds
Bug 6701 - login timeout is in seconds
Bug 6701 - login timeout is in seconds

Description Nicole C. Engard 2011-08-10 14:45:16 UTC
says seconds, but seems to actually be milliseconds
Comment 1 Nicole C. Engard 2011-08-10 15:26:37 UTC Comment hidden (obsolete)
Comment 2 MJ Ray (software.coop) 2011-08-10 23:38:24 UTC Comment hidden (obsolete)
Comment 3 Ian Walls 2011-08-11 15:30:11 UTC
Easy to read and accurate.  Marking as Passed QA.
Comment 4 Chris Cormack 2011-08-12 02:11:49 UTC
Pushed, please test
Comment 5 Dobrica Pavlinusic 2012-03-27 13:02:55 UTC
Excuse my ignorance, but from looking into C4::Auth checkauth, it seems to me that timeout is in seconds, not miliseconds.

Also code seems to support notation of numeric+d (small case or capital D) to specify timeout in days which is not mentioned.
Comment 6 Dobrica Pavlinusic 2012-03-27 13:20:41 UTC Comment hidden (obsolete)
Comment 7 Dobrica Pavlinusic 2012-03-28 13:42:46 UTC Comment hidden (obsolete)
Comment 8 Chris Nighswonger 2012-04-05 13:53:58 UTC
Created attachment 8919 [details] [review]
Bug 6701 - login timeout is in seconds

I checked in C4/Auth and we are using perl time() for comparison with this value.

I also added description of specifying timeout in days which is available in code.

Robin Sheat suggested to document just lowercase d for days option, to reduce
confusion although uppercase D works as days specifier as well.

Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Comment 9 Chris Nighswonger 2012-04-05 13:55:16 UTC
Comment on attachment 8667 [details] [review]
Bug 6701 - login timeout is in seconds

Signed off
Comment 10 Paul Poulain 2012-04-06 16:23:20 UTC
QA comment: tiny patch passed QA (before string freeze, that's important because the patch is related to sysprefs)
Comment 11 Jared Camins-Esakov 2012-05-09 16:59:05 UTC
This bug will be included in the Koha 3.6.5 release.