Summary: | language on timeout system preference is wrong | ||
---|---|---|---|
Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
Component: | Templates | Assignee: | Dobrica Pavlinusic <dpavlin> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | normal | ||
Priority: | P5 - low | CC: | chris, cnighswonger, dpavlin, koha.sekjal, mjr, paul.poulain |
Version: | 3.6 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
bug 6701 - change timeout to say milliseconds
bug 6701 - change timeout to say milliseconds Bug 6701 - login timeout is in seconds Bug 6701 - login timeout is in seconds Bug 6701 - login timeout is in seconds |
Description
Nicole C. Engard
2011-08-10 14:45:16 UTC
Created attachment 4945 [details] [review] bug 6701 - change timeout to say milliseconds Created attachment 4953 [details] [review] bug 6701 - change timeout to say milliseconds Signed-off-by: MJ Ray <mjr@phonecoop.coop> Easy to read and accurate. Marking as Passed QA. Pushed, please test Excuse my ignorance, but from looking into C4::Auth checkauth, it seems to me that timeout is in seconds, not miliseconds. Also code seems to support notation of numeric+d (small case or capital D) to specify timeout in days which is not mentioned. Created attachment 8647 [details] [review] Bug 6701 - login timeout is in seconds I checked in C4/Auth and we are using perl time() for comparison with this value. I also added description of specifing timeout in days which is available in code. Created attachment 8667 [details] [review] Bug 6701 - login timeout is in seconds I checked in C4/Auth and we are using perl time() for comparison with this value. I also added description of specifying timeout in days which is available in code. Robin Sheat suggested to document just lowercase d for days option, to reduce confusion although uppercase D works as days specifier as well. Created attachment 8919 [details] [review] Bug 6701 - login timeout is in seconds I checked in C4/Auth and we are using perl time() for comparison with this value. I also added description of specifying timeout in days which is available in code. Robin Sheat suggested to document just lowercase d for days option, to reduce confusion although uppercase D works as days specifier as well. Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu> Comment on attachment 8667 [details] [review] Bug 6701 - login timeout is in seconds Signed off QA comment: tiny patch passed QA (before string freeze, that's important because the patch is related to sysprefs) This bug will be included in the Koha 3.6.5 release. |