Summary: | Add Basket number and Invoice number search | ||
---|---|---|---|
Product: | Koha | Reporter: | Srdjan Jankovic <srdjan> |
Component: | Acquisitions | Assignee: | Srdjan Jankovic <srdjan> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | enhancement | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, koha.sekjal, nengard, paul.poulain, robin |
Version: | 3.6 | ||
Hardware: | All | ||
OS: | All | ||
See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7085 | ||
GIT URL: | Change sponsored?: | Sponsored | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | |||
Bug Blocks: | 6807 | ||
Attachments: |
patch
Bug 6721 - improve searching in the acquisitions system [SIGNED-OFF] Bug 6721 - improve searching in the acquisitions system |
Description
Srdjan Jankovic
2011-08-15 00:00:38 UTC
Created attachment 5026 [details] [review] patch A few tests show some errors. #1 - the plus sign isn't available on the search results so I can't redo a search: cgi-bin/koha/acqui/histsearch.pl #2 - the advanced search link on the search results doesn't do anything but show me the results again: cgi-bin/koha/acqui/histsearch.pl #3 - after doing a basket or invoice search clicking 'advanced search' from anywhere brings me back to the last results instead of to the search box .. I can't get back to the search box no matter what I try. See here (this recorded after I did a search): http://screencast.com/t/bxjNDiWQnC #4 - I got trailing whitespace errors when I applied the patch: Applying: bug_6721: Acquisitions: basket and invoice search /home/nengard/kohaclone/.git/rebase-apply/patch:41: trailing whitespace. params: /home/nengard/kohaclone/.git/rebase-apply/patch:48: trailing whitespace. booksellerinvoicenumber /home/nengard/kohaclone/.git/rebase-apply/patch:475: trailing whitespace. /home/nengard/kohaclone/.git/rebase-apply/patch:488: trailing whitespace. warning: 4 lines add whitespace errors. nengard@debian:~/kohaclone$ #1 - acqui/histsearch.pl does not have the same top search as the acquisition home page. I can add it there too, but I don't see the point - that page is actually the search expanded, so new search boxes are present on the page itself #2 #3 is how it used to behave. I can change that while I'm at it, just please tell me what do you want to see there - search criteria selection before/after the results, or just the form when clicking on the advanced search link? #4 I have no idea what it is, will consult with someone I guess with all three of the first things I said I was trying to redo the search and couldn't get to the blank search for to do that. So I was trying to find the plus or the blank form so I could do a new search from the results. Does that make sense? #4 is a patch style thing and not something I think that causes failed QA comments - but thought I should mention it. Basically we need a way to search again and see the blank search form instead of the search results over and over again. The search box the hist page uses is only used by that, and virtually identical to the regular one. So now it uses the regular one. That'll address #1. I don't think the advanced search link should give you results immediately. That's pretty strange. Created attachment 5111 [details] [review] Bug 6721 - improve searching in the acquisitions system This allows a basket to be searched for by name or invoice number from anywhere in the acquisitions system. It is accessible by clicking on "orders search", clicking the '[+]' and filling in the basket or invoice no. fields. Author: Srdjan Jankovic <srdjan@catalyst.net.nz> Author: Robin Sheat <robin@catalyst.net.nz> New version attached that hopefully addresses the issues here. Created attachment 5117 [details] [review] [SIGNED-OFF] Bug 6721 - improve searching in the acquisitions system This allows a basket to be searched for by name or invoice number from anywhere in the acquisitions system. It is accessible by clicking on "orders search", clicking the '[+]' and filling in the basket or invoice no. fields. Author: Srdjan Jankovic <srdjan@catalyst.net.nz> Author: Robin Sheat <robin@catalyst.net.nz> Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> There were still trailing whitespace errors, but I don't think those cause it to fail QA so I have signed off. Code is largely additive, and I've read through the portions that reimplement existing functionality. Patch is cleanly rewritten and on-topic. Marking as Passed QA. Pushed please test I think i've found a bug, consequence of this patch. If I search in the breadcrumb, on top, there are results If I open "advanced search", I can't get any result I've investigated, and I think it's because of if (defined $title) { ... add WHERE } title is always defined, even if it's empty. (same for author & bookseller name) Ca others reproduce this behaviour ? In this case, we should probably just have if ($title) (tested quickly, seems to solve the problem) the if (defined $title) was in the original code too, does it occur there? I can't reproduce it with a quick experiment: 1) go to acquisitions 2) in the search form, click 'Orders Search' and then 'Advanced Search' 3) put a value in the Vendor field (e.g. 'a') 4) hit search, and I get plenty of results. Does this differ from what you were trying? Very strange: * if I enter a vendor or a title from the search tab on top of the screen (Orders Search), both work * if I reach the koha/acqui/histsearch.pl and enter the same values, I can't get any result * If I just remove the defined, I get results Tested in english, so it's not a translation problem No idea. The patch is in the master, and I got results on koha/acqui/histsearch.pl for vendor Invoice and basket number/name search work on current master/3.6. The problems Paul notes with advanced order search should be solved with the patch for bug 7085. |