Bug 6724

Summary: Holds Ratio does not allow decimals
Product: Koha Reporter: Joy Nelson <1joynelson>
Component: CirculationAssignee: Brett Wilkins <brett>
Status: CLOSED FIXED QA Contact: Bugs List <koha-bugs>
Severity: normal    
Priority: PATCH-Sent (DO NOT USE) CC: brett, chris, gmcharlt, koha.sekjal
Version: 3.4   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: bug 6724: enable decimals on values greater than 1
Separating perl standard uses from koha uses
bug 6724: enable decimals on values greater than 1
bug 6724: enable decimals on values greater than 1
Signed-off patches, squashed

Description Joy Nelson 2011-08-15 16:47:51 UTC
Holds Ratio report does not allow decimals.  When decimal is entered (1.5) as the ratio, the system reverts to the default value.
Comment 1 Brett Wilkins 2011-08-29 05:56:12 UTC Comment hidden (obsolete)
Comment 2 Brett Wilkins 2011-08-29 05:57:47 UTC Comment hidden (obsolete)
Comment 3 Brett Wilkins 2011-08-29 06:03:21 UTC Comment hidden (obsolete)
Comment 4 Brett Wilkins 2011-08-29 06:03:42 UTC Comment hidden (obsolete)
Comment 5 Owen Leonard 2011-08-29 14:26:30 UTC
Created attachment 5210 [details] [review]
Signed-off patches, squashed

Before applying the patch entering a value like "1.5" would return the same results as leaving the default "3." After applying the patch I get revised results using the "1.5" value.
Comment 6 Brett Wilkins 2011-08-29 23:14:11 UTC
It occurs to me that we could do away with the if-not-defined block, as undef += 0 == 0.

Shouldn't worry about it for now, though?
Comment 7 Ian Walls 2011-09-06 13:56:34 UTC
Math-only patch, easy to read, marking as Passed QA
Comment 8 Chris Cormack 2011-09-06 20:53:55 UTC
Pushed, please test
Comment 9 Chris Nighswonger 2011-10-26 18:02:22 UTC
The fix for this bug was published in the 3.4.5 release. If you were the reporter of this bug, please take time to verify the fix and update the status of this bug report accordingly. If the bug is fixed to your satisfaction, please close this report.