Summary: | Make patron duplicate matching flexible | ||
---|---|---|---|
Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
Component: | Patrons | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | danielle, emma.perks, gmcharlt, jonathan.druart, kelly, lucas, marjorie.barry-vila, martin.renvoize, Niamh.WalkerHeadon |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
The new system preference 'PatronDuplicateMatchingAddFields' adds more flexibility in the de-duplication of patrons.
Prior to this change only surname, firstname and dateofbirth where used. Now the list of fields is configurable.
|
Version(s) released in: |
20.11.00
|
Circulation function: | |||
Attachments: |
Bug 6725: Make patron duplicate matching flexible
Bug 6725: Make patron duplicate matching flexible Bug 6725: Make patron duplicate matching flexible Bug 6725: Make patron duplicate matching flexible Bug 6725: (QA follow-up) Slightly rephrase PatronDuplicateMatchingAddFields |
Description
Nicole C. Engard
2011-08-15 18:29:06 UTC
Valid - needed Still valid. Yes this would be super helpful! I would agree . CLI options would be nice too. ;) Created attachment 107824 [details] [review] Bug 6725: Make patron duplicate matching flexible This patch adds a new system preference PatronDuplicateMatchingAddFields to list the patron's attributes to use for deduplication. The default value is surname, firstname and dateofbirth to keep existing behaviour. Test plan: 0. Apply the patch and execute the update DB entry 1. Create a new patron with surname, firstname 2. Create another patron with the same surname, firstname values => Confirm you get the duplicate warning 3. Modify the syspref to edit the list of attributes used to dedup 4. Repeat 1 and 2 with different values and confirm that you get the behaviours you expect Note: This is only impacting the add patron form from the UI, not the import patrons tool. Created attachment 107846 [details] [review] Bug 6725: Make patron duplicate matching flexible This patch adds a new system preference PatronDuplicateMatchingAddFields to list the patron's attributes to use for deduplication. The default value is surname, firstname and dateofbirth to keep existing behaviour. Test plan: 0. Apply the patch and execute the update DB entry 1. Create a new patron with surname, firstname 2. Create another patron with the same surname, firstname values => Confirm you get the duplicate warning 3. Modify the syspref to edit the list of attributes used to dedup 4. Repeat 1 and 2 with different values and confirm that you get the behaviours you expect Note: This is only impacting the add patron form from the UI, not the import patrons tool. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> A nice enhancement that works well.. the code is clear and makes sense and we're passing the qa scripts.. Signing off. Created attachment 107859 [details] [review] Bug 6725: Make patron duplicate matching flexible This patch adds a new system preference PatronDuplicateMatchingAddFields to list the patron's attributes to use for deduplication. The default value is surname, firstname and dateofbirth to keep existing behaviour. Test plan: 0. Apply the patch and execute the update DB entry 1. Create a new patron with surname, firstname 2. Create another patron with the same surname, firstname values => Confirm you get the duplicate warning 3. Modify the syspref to edit the list of attributes used to dedup 4. Repeat 1 and 2 with different values and confirm that you get the behaviours you expect Note: This is only impacting the add patron form from the UI, not the import patrons tool. Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Created attachment 108320 [details] [review] Bug 6725: Make patron duplicate matching flexible This patch adds a new system preference PatronDuplicateMatchingAddFields to list the patron's attributes to use for deduplication. The default value is surname, firstname and dateofbirth to keep existing behaviour. Test plan: 0. Apply the patch and execute the update DB entry 1. Create a new patron with surname, firstname 2. Create another patron with the same surname, firstname values => Confirm you get the duplicate warning 3. Modify the syspref to edit the list of attributes used to dedup 4. Repeat 1 and 2 with different values and confirm that you get the behaviours you expect Note: This is only impacting the add patron form from the UI, not the import patrons tool. Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 108321 [details] [review] Bug 6725: (QA follow-up) Slightly rephrase PatronDuplicateMatchingAddFields Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 20.11, thanks to everybody involved! enhancement will not be backported to 20.05.x |