Summary: | When SMS is enabled the messaging table is misaligned | ||
---|---|---|---|
Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | normal | ||
Priority: | P5 - low | CC: | adrien.saurat, chris, koha.sekjal |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | |||
Bug Blocks: | 18692 | ||
Attachments: |
extra column
Proposed fix [SIGNED-OFF] Fix for Bug 6726 - When SMS is enabled the messaging table is misaligned [SIGNED-OFF] Follow-up fix for Bug 6726 - When SMS is enabled the messaging table is misaligned |
Description
Nicole C. Engard
2011-08-15 22:40:46 UTC
Created attachment 5024 [details]
extra column
Created attachment 5029 [details] [review] Proposed fix The SMS section of the template was commented out in the patch pushed for Bug 5889, 'Allow message names to be translatable' with the comment 'fixing columns overflow.' That seems to have been a cosmetic fix for what I can only imagine was a different bug? Also fixing a T:T variable scope error. After applying this patch the "SMS" column in the Patron messaging preferences should appear when the SMSSendDriver preference is not empty. Created attachment 5039 [details] [review] [SIGNED-OFF] Fix for Bug 6726 - When SMS is enabled the messaging table is misaligned The SMS section of the template was commented out in the patch pushed for Bug 5889, 'Allow message names to be translatable' with the comment 'fixing columns overflow.' That seems to have been a cosmetic fix for what I can only imagine was a different bug? Also fixing a T:T variable scope error. After applying this patch the "SMS" column in the Patron messaging preferences should appear when the SMSSendDriver preference is not empty. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> a follow up is needed because I forgot to report that this is happening in the OPAC as well, but I've signed off on the staff client fix. Pushed the patch, resetting patch status as a follow up is needed for the staff client Created attachment 5118 [details] [review] [SIGNED-OFF] Follow-up fix for Bug 6726 - When SMS is enabled the messaging table is misaligned Corresponding fix for the OPAC Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> follow up signed off Simple template-only fixes, easy to read, marking both as Passed QA Pushed the follow up, please test The fix for this bug was published in the 3.4.5 release. If you were the reporter of this bug, please take time to verify the fix and update the status of this bug report accordingly. If the bug is fixed to your satisfaction, please close this report. Is the table still ok with SMS disabled ? (when I try, only my Item Checkout and Item Check-in lines look good) |