| Summary: | Guarantor search broken on translated templates | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
| Component: | I18N/L10N | Assignee: | Frédéric Demians <f.demians> |
| Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
| Severity: | critical | ||
| Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, paul.poulain |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| URL: | /cgi-bin/koha/members/guarantor_search.pl?category_type=C | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Proposed patch
[SIGNED-OFF] Bug 6750 Guarantor search broken on translated templates |
||
Created attachment 5247 [details] [review] Proposed patch Created attachment 5272 [details] [review] [SIGNED-OFF] Bug 6750 Guarantor search broken on translated templates Fix the JavaScript to avoid implementing complex string substitution into JS function call. This patch solves the bug and keep the ability to copy borrower's address, name, etc., containing new line, simple quote, etc. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> js changes, pushed please test The fix for this bug was published in the 3.4.5 release. If you were the reporter of this bug, please take time to verify the fix and update the status of this bug report accordingly. If the bug is fixed to your satisfaction, please close this report. |
To reproduce: 0) Select a language != English 1) Add new child patron 2) Click on 'Set to patron' New window for guarantor search opens with following error message: 'Software error: Template process failed: file error - parse error - /home/koha/kohaclone/koha-tmpl/intranet-tmpl/prog/de-DE/modules/members/guarantor_search.tt line 83: unexpected token (=) [% "'[%" |replace('\n',="|replace('\n'," |replace('\r',="|replace('\r'," '\\r')="'\\r')" resultsloo.zipcode="resultsloo.zipcode" resultsloo.address2="resultsloo.address2" resultsloo.city="resultsloo.city" '\\n')="'\\n')" '",="'"," resultsloo.firstname="resultsloo.firstname" resultsloo.streetnumber="resultsloo.streetnumber" value="Auswählen" resultsloo.address="resultsloo.address" %] at /home/koha/kohaclone/C4/Templates.pm line 119. For help, please send mail to the webmaster (webmaster@koha-dev), giving this error message and the time and date of the error. Problem exists in master and 3.4.3. Tested with German and French.