Summary: | Longer userid field | ||
---|---|---|---|
Product: | Koha | Reporter: | Savitra Sirohi <savitra.sirohi> |
Component: | Patrons | Assignee: | Navya V P <navya.vp> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | enhancement | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, f.demians, gmcharlt, koha.sekjal, kohapatch, nengard |
Version: | 3.6 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Longer userid field
With updated DB version xxx Bug 6761 - Longer userid field |
Description
Savitra Sirohi
2011-08-22 04:35:31 UTC
Created attachment 5354 [details] [review] Longer userid field Version numbers should only be assigned by the RM. The kohaversion file shouldn't be in this patch and the updatedatabase file should not say: +$DBversion = "3.05.00.011"; it should instead say: +$DBversion = "3.05.00.XXX"; Created attachment 5374 [details] [review] With updated DB version xxx There is still the kohaversion.pl file in the first patch. Can you make this one patch so that the first patch doesn't break things before applying the second? Nicole: Apply second patch only no need for first one. Comment on attachment 5354 [details] [review] Longer userid field marking obsolete since it's not necessary sorry for the delay - this doesn't apply: With updated DB version xxx Apply? [yn] y Applying: Bug 6761 - Longer userid field with $DBversion = "3.05.00.XXX"; /home/nengard/kohaclone/.git/rebase-apply/patch:33: trailing whitespace. error: patch failed: installer/data/mysql/kohastructure.sql:244 error: installer/data/mysql/kohastructure.sql: patch does not apply Patch failed at 0001 Bug 6761 - Longer userid field with $DBversion = "3.05.00.XXX"; When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". Patch left in /tmp/With-updated-DB-version-xxx-wj4pw_.patch nengard@debian:~/kohaclone$ Created attachment 5760 [details] [review] Bug 6761 - Longer userid field Simple change to read; adjusts both kohastructure.sql and updatedatabase accordingly. One question, out of curiousity mostly: why 75? Consider this my sign off as well: Marking as Passed QA Pushed, please test Included in 3.6 prior to 3.6.5. |