Summary: | Template variable scope errors in holds template | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | normal | ||
Priority: | P5 - low | CC: | chris, koha.sekjal |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 5917 | ||
Attachments: |
Each table of existing holds should show a title
No patron name shows in error message Proposed fix Multiple holds after correction After correction, patron name appears in error message |
Created attachment 5104 [details]
No patron name shows in error message
Error should read "[Patron name] already has a hold on this item"
Created attachment 5105 [details] [review] Proposed fix Created attachment 5106 [details]
Multiple holds after correction
Created attachment 5107 [details]
After correction, patron name appears in error message
Going to give this one a double-jump: please consider this my sign off, as well as the passing of the QA. Template only change, T:T scope fix, easy to read, documented VERY well with screen shots. Pushed please test |
Created attachment 5103 [details] Each table of existing holds should show a title I've found two template variable scope errors in request.tt: One prevents the display of titles when the user is placing holds on multiple items. The other prevents the display of the patron information when there is a error placing a hold.