| Summary: | Getting rid of some RIS format export errors and warnings | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Marcel de Rooy <m.de.rooy> |
| Component: | OPAC | Assignee: | Marcel de Rooy <m.de.rooy> |
| Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
| Severity: | minor | ||
| Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, gmcharlt, paul.poulain |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 6822 | ||
| Bug Blocks: | 5780 | ||
| Attachments: |
Patch
Revised patch signed-off patch 6769 Getting rid of some RIS errors/warnings |
||
|
Description
Marcel de Rooy
2011-08-24 14:15:28 UTC
Created attachment 5115 [details] [review] Patch Test it with: http://yourserver.com/cgi-bin/koha/opac-export.pl?bib=yourbibnumber&format=ris&op=export Replace your server and biblionumber! Forgot to mention: Adding CRs (carriage returns) before LF (linefeed) for Windows users, downloading this format. Assume that CR does not hurt the Linux downloader. I'm curious whether you're getting valid RIS exports? The patch seems to work--I'm not getting errors in the log after applying it. But with our without the patch my RIS exports are almost completely empty: TY - BOOK ER - I have something like: TY - BOOK AU - Manca, Angelo TI - Vermeer: pingo ergo sum T2 - Collezione MercatorSN - 8872552575 PY - 2005/// CY - Firenze PB - Firenze Atheneum KW - schilderijen KW - Vermeer, Johannes, KW - geometrie en kunst ER - Will send a revision for the missing newline after T2 (as in the above example). Created attachment 5116 [details] [review] Revised patch Fixing two missing newlines also.. Created attachment 5231 [details] [review] signed-off patch Also received a user report to the effect that RIS output with this patch installed is being successfully parsed by Reference Manager. Created attachment 5740 [details] [review] 6769 Getting rid of some RIS errors/warnings Removing unnecessary warnings. Some were based on errors in the script. Others are removed by adding debug flag and disabling debugging mode by default. Adding carriage returns for Windows users, assuming that it does not hurt the Linux users. (Perhaps a future option?) Test it with: http://yourserver.com/cgi-bin/koha/opac-export.pl?bib=yourbibnumber&format=ris&op=export [replace server and biblionumber] Revision of Aug 24: Fixed two missing newlines too. Signed-off-by: Steven Callender <stevecallender@esilibrary.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> (removed comment "240811 marcelr during QA" QA comment * description & test plan clear * cosmetic (remove warnings) patch * I just removed a "240811 marcelr", that is something we should not have in code, as it's in git repo marking passed QA Pushed please test |