Bug 6773

Summary: CircAutoCompl uses unlimited query
Product: Koha Reporter: Ian Walls <koha.sekjal>
Component: Architecture, internals, and plumbingAssignee: Ian Walls <koha.sekjal>
Status: CLOSED FIXED QA Contact: Bugs List <koha-bugs>
Severity: minor    
Priority: PATCH-Sent (DO NOT USE) CC: chris
Version: 3.6   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on:    
Bug Blocks: 2084    
Attachments: Signed Off Patch
Signed off Patch (minor revision to text)

Description Ian Walls 2011-08-25 02:11:22 UTC
The SQL in circ/ysearch.pl is unlimited as to the number of results it returns, and since it's called for each character typed into the patron search interface, databases with many patrons (100,000+) can experience resource drain.  Further, since the interface only returns 10 results at a time, the bulk of the work done by the query goes to waste.

The SQL in circ/ysearch.pl should limit to 10 results only, and the system preference text in the staff client should note this limitation, for the administrator's knowledge.
Comment 1 Ian Walls 2011-09-23 13:45:40 UTC Comment hidden (obsolete)
Comment 2 Ian Walls 2011-09-23 13:48:53 UTC
Created attachment 5567 [details] [review]
Signed off Patch (minor revision to text)

Adds LIMIT 10 to SQL search, since only 10 results are returned in the interface at the time.

(minor language issue in circ.pref... fixed in this update)
Comment 3 Chris Cormack 2011-09-25 02:06:00 UTC
Nice change, pushed please test
Comment 4 Ian Walls 2011-11-15 12:41:07 UTC
Fix is now committed, marking as resolved.