Summary: | Add Checkin tab to patron search tool | ||
---|---|---|---|
Product: | Koha | Reporter: | Savitra Sirohi <savitra.sirohi> |
Component: | Circulation | Assignee: | shinoy m <shinoy.m> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | enhancement | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, gmcharlt, koha.sekjal, kohapatch, nengard, paul.poulain |
Version: | 3.6 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Add Checkin tab to patron search tool
Bug 6776 - Add Checkin tab to patron search tool Add Checkin tab to patron search tool Add Checkin tab to patron search tool |
Description
Savitra Sirohi
2011-08-25 04:34:53 UTC
Created attachment 5376 [details] [review] Add Checkin tab to patron search tool Add Checkin tab to patron search tool Created attachment 5745 [details] [review] Bug 6776 - Add Checkin tab to patron search tool Add check-in as an option in patron-search.inc, thus allowing a checkin tab to be available in several patron and circulation pages Signed-off-by: Amit Gupta <amit.gupta@osslabs.biz> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> QA comment: trivial patch, correctly spelled, usefull addition even if all other search tabs have usually 3 tabs, marking passed QA Does not respect checkin permissions like circulation/circ-search.inc does. Needs to be wrapped in [% IF ( CAN_user_circulate ) %] Created attachment 5761 [details] [review] Add Checkin tab to patron search tool Add Checkin tab to patron search tool wrapped in [% IF ( CAN_user_circulate ) %] QA comment, sorry amit, another comment: please don't use tabs, but 4 spaces. It would also be better to have: + </div> + [% END %] instead of + </div>[% END %] I almost missed the END and thought it would not work ! Thank you for resubmitting with the permissions change! One other small bit, not a blocker to QA but something I noticed; since Checkout and Checkin require the same permissions, you can wrap the tabs in the same [% if %] block, instead of having conditionals individually for both tabs. This is just a shortcut, not important, and your way does allow for us to more easily differentiate checkin and checkout permissions in the future. The change from tab to 4 spaces is requested; putting [% END %] on it's own line is optional. Created attachment 5766 [details] [review] Add Checkin tab to patron search tool Using space instead of tab. Thank you for your diligence on this, Amit. I count the previous signoffs as still good, and include my own. Passed QA. I would also like to comment that we don't have a strict rule about tabs versus spaces in the templates, although maybe we should. There is also no style rule about Template:Toolkit tag placement. These could be subjects of future template style discussions, but shouldn't be a barrier to QA until rules are in place. Pushed please test Seems to be working. Closing. |