Summary: | False detection of index names in Search; make index names case insensitive | ||
---|---|---|---|
Product: | Koha | Reporter: | Marcel de Rooy <m.de.rooy> |
Component: | Searching | Assignee: | Marcel de Rooy <m.de.rooy> |
Status: | CLOSED FIXED | QA Contact: | Ian Walls <koha.sekjal> |
Severity: | critical | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, f.demians, paul.poulain |
Version: | 3.6 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Patch
Signed-off patch Follow up fix for hyphens in index names Bug 6786: Follow up fixing index names with hyphens |
Description
Marcel de Rooy
2011-08-25 11:17:35 UTC
Created attachment 5145 [details] [review] Patch *** Bug 6317 has been marked as a duplicate of this bug. *** Created attachment 5251 [details] [review] Signed-off patch I can confirm the bug and the solution. QA comment * perfect test case * small patch, nothing to say from a QA POV marking passed QA ! Pushed, please test Hi, this breaks searches for Control-number as used to link back from analytics to serials using $w in MARC21. To test: - Add a record and fill in 001 - Try to search for Control-number:<001> in a keyword search This needs to be reverted until a better fix can be found that does not break existing features. (In reply to comment #6) > this breaks searches for Control-number as used to link back from analytics to > serials using $w in MARC21. > > This needs to be reverted until a better fix can be found that does not break > existing features. Good catch, Katrin. I think we should not revert it; only a small change in the regex in buildQuery is needed. Problem here seems to be the hyphen in Control-number. I tested this one: /(?:^|\W)([\w-]+)(,[\w-]+)*[:=]/g And it seems to work. I hope to send a follow up patch for this tomorrow. If you are faster, that is fine too. Created attachment 6572 [details] [review] Follow up fix for hyphens in index names Created attachment 6573 [details] [review] Bug 6786: Follow up fixing index names with hyphens Adds hyphen to regex looking for index names in buildQuery. Test by searching on Control-number=... Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> QA Request for Paul or Ian: Could you please set this to Passed QA and push it. Resolves searching on index names with hyphen. Can and should be applied to 3.6.X too. Adds hyphen back into regex, which is required for many/most of the search indexes in bib1.att. Please note that / is also used in several of the bib1.att indexes... now as to whether we actually support those particular indexes, I'm not sure, but theoretically, we should probably also include regex matching for / as well. Passed QA follow-up patch pushed, please test Chris: the patch was pushed on new/bug_6786 branch, but it should have been a follow-up. Where did you pushed the initial fix ? did I missed something ? I see both patches in master and 3.6.x now. Search for "Control-number" works in master. |