| Summary: | hide receive option if there is nothing to receive | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
| Component: | Acquisitions | Assignee: | Samuel Crosby <scrosby000> |
| Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | chris, scrosby000, tomascohen, veron |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
vendor search
Potential bug fix Bug 6820 - hide receive option if there is nothing to receive [Signed-off] Bug 6820 - hide receive option if there is nothing to receive [PASSED QA] Bug 6820 - hide receive option if there is nothing to receive |
||
Created attachment 23920 [details] [review] Potential bug fix Just put the receive button creation in an if statement. Check the commit message for testing instructions. Created attachment 37296 [details] [review] Bug 6820 - hide receive option if there is nothing to receive The "receive shipment" button appears even if there are no orders to receive. This patch hides the button if there are no orders. To test the patch: 1. Go to "aquisitions" 2. Create a vendor 3. As the newly created vendor has no orders, there will now be no "receive shipment" button 4. Create a basket 5. Go back to the vendor search 6. The button should now appear for that vendor I've also tested it with a mix of vendors with and without baskets in the same search. Created attachment 37318 [details] [review] [Signed-off] Bug 6820 - hide receive option if there is nothing to receive The "receive shipment" button appears even if there are no orders to receive. This patch hides the button if there are no orders. To test the patch: 1. Go to "aquisitions" 2. Create a vendor 3. As the newly created vendor has no orders, there will now be no "receive shipment" button 4. Create a basket 5. Go back to the vendor search 6. The button should now appear for that vendor I've also tested it with a mix of vendors with and without baskets in the same search. Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 37339 [details] [review] [PASSED QA] Bug 6820 - hide receive option if there is nothing to receive The "receive shipment" button appears even if there are no orders to receive. This patch hides the button if there are no orders. To test the patch: 1. Go to "aquisitions" 2. Create a vendor 3. As the newly created vendor has no orders, there will now be no "receive shipment" button 4. Create a basket 5. Go back to the vendor search 6. The button should now appear for that vendor I've also tested it with a mix of vendors with and without baskets in the same search. Followed test plan, works as expected. Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Patch pushed to master. Thanks Samuel! |
Created attachment 5227 [details] vendor search Maybe we should hide the receive shipment link on the vendor search if there is nothing to receive - or rename it to say 'received shipments' since that's what you see when you go there.