Summary: | Diacritics in Pootle/po files are broken in source text | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | I18N/L10N | Assignee: | Chris Cormack <chris> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | blocker | ||
Priority: | P1 - high | CC: | chris, f.demians, koha.sekjal, paul.poulain |
Version: | 3.6 | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | 6752 | ||
Bug Blocks: | |||
Attachments: |
pootle screenshot
Bug 6895 : First attempt at fixing the diacritics bug signed off patch Bug 6895 : First attempt at fixing the diacritics bug Proposed patch Bug 6895 Diacritics in Pootle/po files are broken in source text |
Definitely a bug not a new feature, looking into this now, with the hope of getting it fixed before string freeze I have found the problem binmode( OUTPUT, ":utf8" ); In xgettext.pl is causing the problems, without it though we get this Wide character in print at ./xgettext.pl line 230. Wide character in print at ./xgettext.pl line 230. /tmp/chKkLCrt0N:53997:14: invalid multibyte sequence /tmp/chKkLCrt0N:77820:9: invalid multibyte sequence msgmerge: found 2 fatal errors Will look into fixing the wide characters now Created attachment 5709 [details] [review] Bug 6895 : First attempt at fixing the diacritics bug This is a fairly hacky solution, a counter patch would be more than welcome I am testing this and a first test with 3.4.5 looks very promising. I have updated the German po files using 'perl translate update de-DE'. Not a lot of strings need retranslating and all the 'candidates' like names with diacritics from the about page seem to show up in my list. Created attachment 5730 [details] [review] signed off patch Created attachment 5858 [details] [review] Bug 6895 : First attempt at fixing the diacritics bug This is a fairly hacky solution, a counter patch would be more than welcome Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Updated, translated and installed German po files after applying this patch. No problems found. Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> QA comment * it used to work in 3.2-, so it must have been caused by the switch to T::T. Investigating xgettext.pl history, it seems it has been added by a patch from chris, in april. * I don't know what kind of counter-patch should be sent, the patch switches back to the previous behaviour that was OK * diacritics in english version are almost only in about.pl, in the contributor list. It means they are not translated, but names does not need to be translated, so the problem is not a major one (that's why noone spotted it before) * why is there -<p class="submit"><input id="submit" type="submit" value="Login »" tabindex="4" /></p> +<p class="submit"><input id="submit" type="submit" value="Login" tabindex="4" /></p> and -<p class="submit"><input id="submit" type="submit" value="Login »" tabindex="4" /></p> +<p class="submit"><input id="submit" type="submit" value="Login" tabindex="4" /></p> in the patch ? If i'm not mistaking it's not related to this problem. (the macles.tt has probably be used for testing purposes. Chris, please resubmit a patch removing those lines, i'll mark passed QA, as it fixes the problem. No those characters break the translation, along with the fixed diacritics, changing the to actual utf8 characters makes the string translatable. OK, passed QA then Patch pushed, please test (my 1st push!!!) (cced the translation manager) It seems this bug has reoccured in 3.6.4. The diacritics are broken again in the source files, requiring to be retranslated. Created attachment 7851 [details] [review] Proposed patch Apply on HEAD/3.6.x Very needed for next 3.6.x (3.6.5) (In reply to comment #12) > Created attachment 7851 [details] [review] > Proposed patch > > Apply on HEAD/3.6.x > Very needed for next 3.6.x (3.6.5) I wonder how it crept back in? Ah ha! Commit 263dded8 For bug 6752 Yep this patch undoes the accidental regression. Created attachment 7865 [details] [review] Bug 6895 Diacritics in Pootle/po files are broken in source text To test: git checkout 3.6.x cd misc/translator ./tmpl_process3.pl update -i ../../koha-tmpl/opac-tmpl/prog/en/ \ -s ./po/fr-FR-i-opac-t-prog-v-3006000.po -r po/fr-FR-i-opac-t-prog-v-3006000.po contains broken diacritics for NORMARC strings for example Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Simple patch to fix one-line regression caused by blanket changes in bug 6752. As noted on that bug, there could be such regressions, but we'd have time to catch them. So here's catching. Marking as Passed QA. |
Created attachment 5491 [details] pootle screenshot In Pootle diacritics in terms that are to be translated are broken. (See screenshot for example)