Summary: | increase DEBUG level for *NOISY* Dates.pm init() messages | ||
---|---|---|---|
Product: | Koha | Reporter: | Mason James <mtj> |
Component: | Architecture, internals, and plumbing | Assignee: | Mason James <mtj> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | trivial | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, koha.sekjal, paul.poulain |
Version: | 3.6 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
patch
corrected patch :) Bug 6908 - increase DEBUG level for *NOISY* Dates.pm init() messages |
Description
Mason James
2011-09-22 09:36:22 UTC
Created attachment 5535 [details] [review] patch appiled to MASTER commit 147ae6c665cd25a07471d90afcab3e38ce36d9e0 Merge: d43aa87 9d3a8d9 Author: Chris Cormack <chrisc@catalyst.net.nz> Date: Fri Sep 16 13:53:40 2011 +1200 Merge remote-tracking branch 'kc/new/enh/bug_4877' into kcmaster Created attachment 5536 [details] [review] corrected patch :) oops, a litle typo there folks... Created attachment 6514 [details] [review] Bug 6908 - increase DEBUG level for *NOISY* Dates.pm init() messages Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> QA comment: one line patch, usefull, nothing to say patch pushed, please test This results in the following error types in the log: [Thu Dec 15 16:20:43 2011] [error] [client 10.8.5.33] [Thu Dec 15 16:20:43 2011] opac-detail.pl: Use of uninitialized value $C4::Dates::debug in numeric gt (>) at /usr/share/kohatest36/lib/C4/Dates.pm line 170., referer: http://kohatest36/cgi-bin/koha/opac-search.pl?q=school+census Looks like $debug isn't getting universally set to a numeric value. In the cases where it's not numeric, we get the above error mason, a follow-up patch with something like if ($debug && $debug > 1) { warn "(during init) \@\$self->{'dmy_arrayref'}: " . join( ' ', @{ $self->{'dmy_arrayref'} } ) . "\n"; } instead of if ($debug > 1) { warn "(during init) \@\$self->{'dmy_arrayref'}: " . join( ' ', @{ $self->{'dmy_arrayref'} } ) . "\n"; } welcomed Included in 3.6 prior to 3.6.5. |