Summary: | OPAC display crashes for analytical biblio without 008 field | ||
---|---|---|---|
Product: | Koha | Reporter: | Frédéric Demians <f.demians> |
Component: | OPAC | Assignee: | Frédéric Demians <f.demians> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | normal | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, jcamins, koha.sekjal, paul.poulain |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Proposed patch
Proposed patch Proposed patch [SIGNED-OFF] Bug 6912 Test 008 presence in get CoinS function Bug 6912 Test 008 presence in get CoinS function |
Description
Frédéric Demians
2011-09-25 09:35:52 UTC
Created attachment 5580 [details] [review] Proposed patch Created attachment 5581 [details] [review] Proposed patch Created attachment 5582 [details] [review] Proposed patch (with no warning in logs...) I cannot duplicate this bug. Or if I am duplicating it, I can't tell. What are the symptoms? > I cannot duplicate this bug. Or if I am duplicating it, I can't tell. What are
> the symptoms?
Thanks for testing.
How to reproduce this bug, and test the patch:
- In OPAC, go on a biblio record detail page. Note its biblionumber.
- In another browser tab, go in staff interface, edit the previous
MARC21 biblio record.
- Open the leader editor.
- In 7- Bibliographic level, choose 'a - Monographic component part'
- Click OK, and save the the biblio record.
- Switch to the OPAC tab. Refresh the page. You get this error
message:
Software error:
Can't call method "data" on an undefined value at
/home/tamil/client/lesc/kohaclone/C4/Biblio.pm line 1220.
Sorry, I forgot something. When editing the biblio record leader, you also have to remove the 008 field if you have one. Created attachment 5804 [details] [review] [SIGNED-OFF] Bug 6912 Test 008 presence in get CoinS function Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> I see. There is no case when a record should be without an 008, but, since it surely happens, this is very real issue. The patch works exactly as you said. Created attachment 5859 [details] [review] Bug 6912 Test 008 presence in get CoinS function Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> QA comment : * trivial patch & good coding style * good description * works as announced passed QA Yup, straight forward patch, easy to read, agreed on passed QA No strings changed, pushing There have been no further reports of problems so I am marking this bug resolved. |